[Merged by Bors] - update archetypes for run criterias #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
run-criteria-query
branch
from
a0803a4 to
053f4ae
Compare
NathanSWard
reviewed
May 16, 2021
mockersf
added
C-Bug
mockersf
force-pushed
the
run-criteria-query
branch
from
053f4ae to
c0494d1
Compare
mockersf
force-pushed
the
run-criteria-query
branch
from
c0494d1 to
ea6801d
Compare
alice-i-cecile
approved these changes
Jul 12, 2021
Ratysz
approved these changes
Jul 12, 2021
Contributor
Ratysz
left a comment
Ratysz
left a comment
There was a problem hiding this comment.
Oh, hm. I guess exclusive systems suffer from the same bug?
Member
|
Yup I've already fixed the exclusive system bug in the pipelined rendering branch. Planned on upstreaming but never got around to it :) fn run(&mut self, world: &mut World) {
let archetypes = world.archetypes();
let new_generation = archetypes.generation();
let old_generation = std::mem::replace(&mut self.archetype_generation, new_generation);
let archetype_index_range = old_generation.value()..new_generation.value();
for archetype in archetypes.archetypes[archetype_index_range].iter() {
self.system.new_archetype(archetype);
}
self.system.run((), world);
self.system.apply_buffers(world);
} |
NathanSWard
approved these changes
Jul 12, 2021
Member
|
We should include the exclusive system fix in the same PR right? |
Member
Author
added fix and test for exclusive systems |
alice-i-cecile
approved these changes
Jul 12, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
Ratysz
approved these changes
Jul 13, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
fixes #2000 archetypes were not updated for run criteria on a stage or on a system set
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
fixes bevyengine#2000 archetypes were not updated for run criteria on a stage or on a system set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2000
archetypes were not updated for run criteria on a stage or on a system set