Beef up migration guide for getrand effects on web
#21162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Bluefinger can I get your review here? |
alice-i-cecile
added
C-Docs
DaAlbrecht
reviewed
Sep 22, 2025
Bluefinger
reviewed
Sep 22, 2025
Bluefinger
reviewed
Sep 22, 2025
BD103
reviewed
Sep 22, 2025
|
|
||
| You may encounter an error like: | ||
|
|
||
| ```toml |
Member
There was a problem hiding this comment.
Suggested change
| ```toml | |
| ```sh |
(Nit) I think setting the syntax highlighting to TOML is misleading, as this is a message you would see in the shell and not in a TOML file.
Member
Author
There was a problem hiding this comment.
I agree that it's misleading, but sh makes the formatting worse, because it's formatted as "shell input". The TOML formatting at least gets the quote right, and I can't leave it untagged or the linter complains.
Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]> Co-authored-by: BD103 <[email protected]>
Co-authored-by: DAA <[email protected]>
DaAlbrecht
approved these changes
Sep 22, 2025
Member
Author
|
Ugh, changing branch has done very bad things to the diff here. I'm going to have to remake this. |
Member
Author
|
Remade the PR targeting the 0.17 branch. |
alice-i-cecile
added a commit
that referenced
this pull request
Sep 22, 2025
# Objective We still need to improve these migration guides, but we cut them from `main`. Fixes #21039. ## Solution Adopt #21162 targeting the 0.17 release branch. Cherrypick the same commits to a new branch targeting the new branch rather than main. --------- Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]> Co-authored-by: BD103 <[email protected]> Co-authored-by: DAA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
getrandpulled in by Updaterand,glamandencaseto latest versions #18047 are both challenging to fix and very disruptive.rand/getrandommigration guide is slightly misleading #21039, which did a great job pointing out potential improvements.Solution
bevy_clihas an easy fix for this and tell people to upgrade