Added StableInterpolate implementations for linear colors.
#18601
Conversation
alice-i-cecile
added
C-Feature
greeble-dev
left a comment
greeble-dev
left a comment
There was a problem hiding this comment.
Could consider reusing impl_componentwise_vector_space? b8d7c35
| #[test] | ||
| pub fn test_color_stable_interpolate() { | ||
| let b = Srgba::BLACK; | ||
| let w = Srgba::WHITE; |
There was a problem hiding this comment.
🤔 Is Srgba actually a linear space?
There was a problem hiding this comment.
I could be wrong but I think the point of color spaces is to use them in a linear space.
IQuick143
left a comment
IQuick143
left a comment
There was a problem hiding this comment.
Seems good, although I'm not personally certain about the impls other than LinearRgba.
JaySpruce
added
S-Ready-For-Final-Review
|
This isn't the place to get into it I guess, but I'm increasingly of the feeling that the color types shouldn't implement That said, all of the colors can still actually implement |
…ine#18601) # Objective Colors currently do not implement `StableInterpolate`, which makes them ineligible for functions like `smooth_nudge` and make some generic APIs awkward. ## Solution Implemented `StableInterpolate` for linear color types that should be uncontroversial. Non-linear types like `Hsl` are not implemented in this PR. ## Testing Added a test that checks implementations are correct.
6 participants
Objective
Colors currently do not implement
StableInterpolate, which makes them ineligible for functions likesmooth_nudgeand make some generic APIs awkward.Solution
Implemented
StableInterpolatefor linear color types that should be uncontroversial. Non-linear types likeHslare not implemented in this PR.Testing
Added a test that checks implementations are correct.