Correct attachment name #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
requested review from
Dautery91,
jasoncdavis0,
rqbacktrace and
vlussenburg
Contributor
|
wondering how we would prevent it from accidentally changing again in the future - ideas? |
Collaborator
Author
We moved it to specific function where we defined constraint for attachment name. Not sure what we can do more if we already defined constraint. |
vlussenburg
approved these changes
Mar 29, 2021
konraddysput
added a commit
that referenced
this pull request
Apr 6, 2021
…se-positive anrs (#69) * Background thread support (#67) * Background thread support * Fixed exception flow * Removed renamed file * Detect false-positive ANRs report and prevent ANR watchdog from sending them (#66) * Detect false-positive ANRs report and prevent ANR watchdog from sending them + anr thread improvements * Fixed typos + better documentation - added Samy's advices * Attachment support (#68) * Attachment support on Android - iOS shouldn't compile * Updated the latest version of backtrace-android libraries and also adjust iOS integration code - code should now compile on iOS * Native attachment support * Attachment improvements * Updated label * Native client updates * Android libraries * Version update * 3.4.0-rc1 * Prevents from reading empty attachments * Arabic language support (#70) * Fixed invalid date in log manager when calendar is unsupported * Use single method to generate UTC timestamps + move it from extension code to static class to avoid unnecessary allocation * Fixed line endings * Updated native library * Removed debug logs from native library * Updated library version * Added invariant culture to rest of the code * native library update * Fixed issue in the readme file * Correct attachment name (#73) * Correct attachment name * Moved constants to const variables * Prepare for final release * Fixed typo in function name * Changelog change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
attachment name started with underscore prefix
_. This diff removes unnecessary underscore from Backtrace API implementation.