Version 3.4.0 - attachment and background thread support, prevent false-positive anrs #69

konraddysput · 2021-03-15T21:30:51Z

Update 3.4.0-rc summary

native/managed attachment support - user can add path to attachments via BacktraceClient Initialize method or via Unity Editor Backtrace Window. Once user add them on the initialization method/game object - it will be available in every report that BacktraceClient will send to Backtrace.
background thread support - now BacktraceClient will report exceptions/unhandled exceptions generated by any background thread.
ANR detection improvements - BacktraceClient won't report anymore ANRs detected when the application goes to the background.
thread.main attribute support - attribute stores an identifier of a main thread. In this situation user can use value available in this attribute to detect main thread.
Backtrace native integration will set _mod_faulting_tid attribute for ANR reports to set default faulting thread.

* Background thread support * Fixed exception flow * Removed renamed file

…ng them (#66) * Detect false-positive ANRs report and prevent ANR watchdog from sending them + anr thread improvements * Fixed typos + better documentation - added Samy's advices

* Attachment support on Android - iOS shouldn't compile * Updated the latest version of backtrace-android libraries and also adjust iOS integration code - code should now compile on iOS * Native attachment support * Attachment improvements * Updated label * Native client updates * Android libraries

jasoncdavis0 · 2021-03-15T21:51:55Z

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Backtrace Unity Release Notes

+## Version 3.4.0


3.4.0-rc1 ?

good-catch I will update a version.

jasoncdavis0

suggest we clarify 3.4.0-rc1 as the version.

vlussenburg · 2021-03-15T23:05:51Z

Tested on iOS

ANR triggers
OOM triggers
native crash triggers
Managed crash triggers

vlussenburg · 2021-03-15T23:47:38Z

Native attachment tested:

Dautery91 · 2021-03-16T14:04:38Z

CHANGELOG.md

 # Backtrace Unity Release Notes

+## Version 3.4.0-rc1
+- native/managed attachment support - user can add path to attachments via BacktraceClient Initialize method or via Unity Editor Backtrace Window. Once user add them on the initialization method/game object - it will be available in every report that BacktraceClient will send to Backtrace.


Not to be too pedantic here, but you should change "Unity Editor Backtrace Window" to "Unity Editor in the BacktraceClient's inspector. In Unity: Inspector <> Window.

thanks, Will make a change.

Dautery91 · 2021-03-16T14:13:17Z

Runtime/Model/BacktraceConfiguration.cs

+            foreach (var path in AttachmentPaths)
+            {
+                result.Add(ClientPathHelper.GetFulLPath(path));
+            }


@konraddysput Corner case you should handle (sorry if I missed it elsewhere: Check for null / empty items in the AttachmentPaths list. Given the user can create that list + amend it via the inspector, they could accidentally leave one of the items empty. I dont think this will throw a null reference exception in that case because I am pretty sure the list would just contain an empty string, but might be worth handling (or at least testing). Let me know what you think

Might make sense to put this in the Initialize method when you assign the value in the config to the client's AttachmentPath property instead. Ill leave that up to you.

User attachment never will be null. Reference:

user attachments:

backtrace-unity/Runtime/Model/BacktraceConfiguration.cs

Line 239 in 753f3a0

if (AttachmentPaths == null || AttachmentPaths.Length == 0)

report attachments:

backtrace-unity/Runtime/Model/BacktraceReport.cs

Line 105 in 753f3a0

AttachmentPaths = attachmentPaths ?? new List<string>();

If the list is empty in both examples - it's fine. If list has empty values it's also fine - we will check if file exists before uploading it to Backtrace. We wont want to check if file exists here in this function because user might want to create them after backtrace client initialization.

Ok great, makes sense. Thanks

@Dautery91 it won't cost us anything to anyway prevents from setting empty strings in editor. I will add anyway a check on the startup. Thanks for pointing this out.

Dautery91 · 2021-03-16T14:24:05Z

Runtime/Native/Android/NativeClient.cs

+                                        AndroidJNI.NewStringUTF("error.type"),
+                                        AndroidJNI.NewStringUTF("Hang"));


[General Note. Making a change not necessary for this pull request] Reading through this made me think: Why are your attribute strings defined in line like this? In your editor code, you have an entire file where you define all of the Labels in one place, and yet these are in line. Seems like following a similar pattern would be a good change both from the perspective of organization AND maintaining documentation. If you have all of the attribute definitions in one place, would be easier for us to ensure any docs are up to date + give users a place in the code to see all of the attributes + quickly link to how they are used. Let's discuss this as an aside

It should be defined in const variables in class definition I agree - but this change might be important/usefull once we will merge implementations for native clients. I think it't an item on my to do list while we will work on native client refactor.

Ok sounds good. Yeah I view this change as primarily a documentation improvement than anything else, so we should just be keeping this in the back of our minds + slot in the work when and where it makes sense.
@vlussenburg

Dautery91

See my comments

* Fixed invalid date in log manager when calendar is unsupported * Use single method to generate UTC timestamps + move it from extension code to static class to avoid unnecessary allocation * Fixed line endings * Updated native library * Removed debug logs from native library * Updated library version * Added invariant culture to rest of the code * native library update * Fixed issue in the readme file

* Correct attachment name * Moved constants to const variables

konraddysput added 3 commits March 15, 2021 19:20

Background thread support (#67)

38f648d

* Background thread support * Fixed exception flow * Removed renamed file

Detect false-positive ANRs report and prevent ANR watchdog from sendi…

55c6efd

…ng them (#66) * Detect false-positive ANRs report and prevent ANR watchdog from sending them + anr thread improvements * Fixed typos + better documentation - added Samy's advices

konraddysput requested review from Dautery91, jasoncdavis0 and vlussenburg March 15, 2021 21:30

konraddysput self-assigned this Mar 15, 2021

Version update

5bf09cd

jasoncdavis0 reviewed Mar 15, 2021

View reviewed changes

3.4.0-rc1

753f3a0

jasoncdavis0 reviewed Mar 15, 2021

View reviewed changes

Dautery91 reviewed Mar 16, 2021

View reviewed changes

konraddysput added 6 commits March 16, 2021 15:43

Prevents from reading empty attachments

f7e6a00

Correct attachment name (#73)

e74af45

* Correct attachment name * Moved constants to const variables

Prepare for final release

fbb5607

Fixed typo in function name

08996bf

Changelog change

d65d0f8

vlussenburg approved these changes Apr 6, 2021

View reviewed changes

konraddysput merged commit ebe06b3 into master Apr 6, 2021

		@@ -1,5 +1,12 @@
		# Backtrace Unity Release Notes

		## Version 3.4.0

		AndroidJNI.NewStringUTF("error.type"),
		AndroidJNI.NewStringUTF("Hang"));

Version 3.4.0 - attachment and background thread support, prevent false-positive anrs #69

Version 3.4.0 - attachment and background thread support, prevent false-positive anrs #69

Uh oh!

Conversation

konraddysput commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update 3.4.0-rc summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasoncdavis0 left a comment

Choose a reason for hiding this comment

Uh oh!

vlussenburg commented Mar 15, 2021

Uh oh!

vlussenburg commented Mar 15, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

konraddysput Mar 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dautery91 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

konraddysput commented Mar 15, 2021 •

edited

Loading

konraddysput Mar 16, 2021 •

edited

Loading