Skip to content

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented May 23, 2019

Issue #, if available:
N/A
Description of changes:
Exclude some additional warnings from cfn-lint
Description of how you validated changes:
Tests run/pass
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian keetonian requested review from praneetap and jlhood May 23, 2019 23:41
@codecov-io
Copy link

Codecov Report

Merging #933 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #933      +/-   ##
===========================================
+ Coverage    94.66%   94.73%   +0.06%     
===========================================
  Files           69       69              
  Lines         3018     3018              
  Branches       562      562              
===========================================
+ Hits          2857     2859       +2     
+ Misses          85       84       -1     
+ Partials        76       75       -1
Impacted Files Coverage Δ
...lator/plugins/application/serverless_app_plugin.py 83.44% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cc0f9...22cb9bc. Read the comment docs.

@praneetap praneetap merged commit 8ccf4fc into develop May 24, 2019
praneetap added a commit to praneetap/serverless-application-model that referenced this pull request May 24, 2019
chore: update test_translator.py (aws#933)
keetonian added a commit that referenced this pull request May 24, 2019
praneetap pushed a commit to praneetap/serverless-application-model that referenced this pull request Jun 5, 2019
brettstack pushed a commit that referenced this pull request Jun 12, 2019
* chore: update test_translator.py (#933)

* fix: partitionalize arn in StepFunctionsExecutionPolicy (#941)

* fix: fix a deprecation warning from jsonschema 3.x (#946)

For example, in https://travis-ci.org/awslabs/serverless-application-model/jobs/538917819:

/home/travis/build/awslabs/serverless-application-model/.tox/py36/lib/python3.6/site-packages/jsonschema/validators.py:893: DeprecationWarning: The metaschema specified by $schema was not found. Using the latest draft to validate, but this will raise an error in the future.
  cls = validator_for(schema)

* feat: openapi version 3 support non-auth changes (#932)

* feat: openapi support for auth usecases (#949)

* chore: Fixing security alerts on the repo

* addressed cr comments
@keetonian keetonian deleted the keetonian-patch-3 branch June 12, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants