feat: openapi version 3 support non-auth changes #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from awslabs/develop
praneetap
changed the title
chore: update test_translator.py (aws#933)
Codecov Report
@@ Coverage Diff @@
## develop #932 +/- ##
===========================================
+ Coverage 94.73% 94.86% +0.12%
===========================================
Files 69 69
Lines 3018 3055 +37
Branches 562 573 +11
===========================================
+ Hits 2859 2898 +39
Misses 84 84
+ Partials 75 73 -2
Continue to review full report at Codecov.
|
keetonian
suggested changes
May 24, 2019
keetonian
reviewed
May 29, 2019
brettstack
reviewed
May 29, 2019
brettstack
reviewed
May 29, 2019
keetonian
reviewed
May 30, 2019
| if self.open_api_version: | ||
| if re.match(SwaggerEditor.get_openapi_versions_supported_regex(), self.open_api_version) is None: | ||
| raise InvalidResourceException( | ||
| self.logical_id, "The OpenApiVersion value must be of the format 3.0.0") |
There was a problem hiding this comment.
nit: 3.0.0 doesn't seem like a format, but I think this is still understandable.
keetonian
approved these changes
May 31, 2019
|
merge develop into oas3
brettstack
approved these changes
Jun 3, 2019
praneetap
added a commit
to praneetap/serverless-application-model
that referenced
this pull request
Jun 5, 2019
brettstack
pushed a commit
that referenced
this pull request
Jun 12, 2019
* chore: update test_translator.py (#933) * fix: partitionalize arn in StepFunctionsExecutionPolicy (#941) * fix: fix a deprecation warning from jsonschema 3.x (#946) For example, in https://travis-ci.org/awslabs/serverless-application-model/jobs/538917819: /home/travis/build/awslabs/serverless-application-model/.tox/py36/lib/python3.6/site-packages/jsonschema/validators.py:893: DeprecationWarning: The metaschema specified by $schema was not found. Using the latest draft to validate, but this will raise an error in the future. cls = validator_for(schema) * feat: openapi version 3 support non-auth changes (#932) * feat: openapi support for auth usecases (#949) * chore: Fixing security alerts on the repo * addressed cr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#191 #627
Description of changes:
Adding OpenApi 3.0 support for non-auth use cases. This adds a global/api flag called OpenApiVersion, which when specified -
Description of how you validated changes:
Added tests, and end to end tests.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.