Skip to content

Conversation

andrewjroth
Copy link

Conforming to the established standard, added three additional policy templates for single permissions related to AWS KMS: kms:Sign, kms:Verify, kms:GetPublicKey

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Conforming to the established standard, added three additional policy templates for single permissions related to AWS KMS:  kms:Sign, kms:Verify, kms:GetPublicKey
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jun 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #2431 (f3ccccd) into develop (e7a1496) will increase coverage by 0.85%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2431      +/-   ##
===========================================
+ Coverage    93.58%   94.43%   +0.85%     
===========================================
  Files           90       98       +8     
  Lines         6124     7266    +1142     
  Branches      1260     1511     +251     
===========================================
+ Hits          5731     6862    +1131     
- Misses         183      195      +12     
+ Partials       210      209       -1     
Impacted Files Coverage Δ
samtranslator/region_configuration.py 77.77% <0.00%> (-22.23%) ⬇️
samtranslator/model/codedeploy.py 90.90% <0.00%> (-9.10%) ⬇️
samtranslator/validator/validator.py 91.80% <0.00%> (-3.85%) ⬇️
samtranslator/model/exceptions.py 97.67% <0.00%> (-2.33%) ⬇️
samtranslator/open_api/open_api.py 90.16% <0.00%> (-1.81%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 68.42% <0.00%> (-0.81%) ⬇️
samtranslator/yaml_helper.py 89.47% <0.00%> (-0.53%) ⬇️
samtranslator/translator/logical_id_generator.py 90.62% <0.00%> (-0.29%) ⬇️
samtranslator/model/api/api_generator.py 94.08% <0.00%> (-0.28%) ⬇️
samtranslator/model/apigateway.py 96.98% <0.00%> (-0.18%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e98f0...f3ccccd. Read the comment docs.

@mndeveci
Copy link
Contributor

mndeveci commented Jul 7, 2022

Thank for your contribution, it looks good in general. Can you also add some unit tests like in this PR? #1929

@mndeveci mndeveci removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Jul 11, 2022
@hoffa hoffa removed the pr/external label Dec 2, 2022
@aahung aahung requested a review from a team as a code owner January 23, 2023 22:59
@xazhao xazhao closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants