Skip to content

feat(policy-templates): add Route53ChangeResourceRecordSetsPolicy #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2021
Merged

feat(policy-templates): add Route53ChangeResourceRecordSetsPolicy #1929

merged 4 commits into from
Mar 1, 2021

Conversation

theBaffo
Copy link
Contributor

@theBaffo theBaffo commented Feb 16, 2021 •
edited
Loading

Issue #, if available: #1930

Description of changes: Add "Route53ChangeResourceRecordSetsPolicy" policy

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@theBaffo
Copy link
Contributor Author

Not sure why, but I got this error "UnboundLocalError: local variable 'patching' referenced before assignment", that's why the AppVeyor build failed.

@sriram-mv
Copy link
Contributor

This looks well formed, Need to investigate on the appveyor failure.

@hawflau
Copy link
Contributor

hawflau commented Feb 23, 2021

Hey @theBaffo it looks like you've defined HostedZoneId in policy_templates.json, but used hostedZoneId (lowercase h) in the tests. Can you update all hostedZoneId to HostedZoneId in the test input and outputs? It will pass the test then.

You can also run make pr before you submit the PR. It will run unit tests in your local machine.

@theBaffo
Copy link
Contributor Author

Hey @theBaffo it looks like you've defined HostedZoneId in policy_templates.json, but used hostedZoneId (lowercase h) in the tests. Can you update all hostedZoneId to HostedZoneId in the test input and outputs? It will pass the test then.

You can also run make pr before you submit the PR. It will run unit tests in your local machine.

Hi @hawflau!

Yes, my bad! I updated hostedZoneId to HostedZoneId as requested, and update the PR. It should be good to go now!

hawflau
hawflau approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@hawflau hawflau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hawflau
hawflau requested changes Feb 24, 2021
View reviewed changes
hoffa
hoffa reviewed Mar 1, 2021
View reviewed changes
hoffa
hoffa approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@hoffa hoffa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌 (Applied description nit above)

@hawflau hawflau merged commit d08d77b into aws:develop Mar 1, 2021
mgrandis pushed a commit to mgrandis/serverless-application-model that referenced this pull request Mar 2, 2021
@theBaffo @mgrandis
feat(policy-templates): add Route53ChangeResourceRecordSetsPolicy (aw…
162b025 
…s#1929)

* feat(policy-templates): add Route53ChangeResourceRecordSetsPolicy

* feat(policy-templates): replace 'hostedZoneId' with 'HostedZoneId'

* feat(policy-templates): remove both Region and AccountId

* Update samtranslator/policy_templates_data/policy_templates.json

Co-authored-by: Chris Rehn <[email protected]>
@mndeveci mndeveci mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawflau hawflau hawflau approved these changes

+1 more reviewer

@hoffa hoffa hoffa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theBaffo @sriram-mv @hawflau @hoffa