Improve exception processing for Route53 with invalid type #2284
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2284 +/- ##
===========================================
+ Coverage 93.58% 94.39% +0.81%
===========================================
Files 90 97 +7
Lines 6124 7086 +962
Branches 1260 1434 +174
===========================================
+ Hits 5731 6689 +958
+ Misses 183 181 -2
- Partials 210 216 +6
Continue to review full report at Codecov.
|
Could you please add more unit test cases to increase the coverage percentage in these files:
|
| if self.domain.get("Route53") is not None: | ||
| route53 = self.domain.get("Route53") | ||
| if route53.get("HostedZoneId") is None and route53.get("HostedZoneName") is None: | ||
| if isinstance(route53, dict): |
There was a problem hiding this comment.
nit: we can just add if not isintance(route53, dict): raise ... so that we don't need to change any of below?
wchengru
force-pushed
the
fixRoute53
branch
2 times, most recently
from
8956ba2 to
47f10dc
Compare
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.