code refactor

Author: wchengru

samtranslator/model/api/api_generator.py

@@ -515,29 +515,28 @@ def _construct_api_domain(self, rest_api):
         record_set_group = None
         if self.domain.get("Route53") is not None:
             route53 = self.domain.get("Route53")
-            if isinstance(route53, dict):
-                if route53.get("HostedZoneId") is None and route53.get("HostedZoneName") is None:
-                    raise InvalidResourceException(
-                        self.logical_id,
-                        "HostedZoneId or HostedZoneName is required to enable Route53 support on Custom Domains.",
-                    )
-                logical_id = logical_id_generator.LogicalIdGenerator(
-                    "", route53.get("HostedZoneId") or route53.get("HostedZoneName")
-                ).gen()
-                record_set_group = Route53RecordSetGroup(
-                    "RecordSetGroup" + logical_id, attributes=self.passthrough_resource_attributes
-                )
-                if "HostedZoneId" in route53:
-                    record_set_group.HostedZoneId = route53.get("HostedZoneId")
-                if "HostedZoneName" in route53:
-                    record_set_group.HostedZoneName = route53.get("HostedZoneName")
-                record_set_group.RecordSets = self._construct_record_sets_for_domain(self.domain)
-            else:
+            if not isinstance(route53, dict):
                 raise InvalidResourceException(
                     self.logical_id,
                     "Invalid property type '{}' for Route53. "
                     "Expected a map defines an Amazon Route 53 configuration'.".format(type(route53).__name__),
                 )
+            if route53.get("HostedZoneId") is None and route53.get("HostedZoneName") is None:
+                raise InvalidResourceException(
+                    self.logical_id,
+                    "HostedZoneId or HostedZoneName is required to enable Route53 support on Custom Domains.",
+                )
+            logical_id = logical_id_generator.LogicalIdGenerator(
+                "", route53.get("HostedZoneId") or route53.get("HostedZoneName")
+            ).gen()
+            record_set_group = Route53RecordSetGroup(
+                "RecordSetGroup" + logical_id, attributes=self.passthrough_resource_attributes
+            )
+            if "HostedZoneId" in route53:
+                record_set_group.HostedZoneId = route53.get("HostedZoneId")
+            if "HostedZoneName" in route53:
+                record_set_group.HostedZoneName = route53.get("HostedZoneName")
+            record_set_group.RecordSets = self._construct_record_sets_for_domain(self.domain)
 
         return domain, basepath_resource_list, record_set_group