Skip to content

fix: unexpected sys.path injection #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: unexpected sys.path injection #2076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions samtranslator/feature_toggle/feature_toggle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
SimpleAccountPercentileDialup,
)

my_path = os.path.dirname(os.path.abspath(__file__))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c2tarun I believe you where the original author of Feature Toggle. Why was this developed in this way? If we remove this, are there any downstream side effects? I assume this was done for a reason, just not sure what it was.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, this is so that we can reference this config file from sam-translate script for testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just for the script, I would rather break that than do patching like this in the lib. We shouldn't need FeatureToggle from that script anyways. Maybe I am missing something but I would error on not overriding sys.path as it's super dangerous.

sys.path.insert(0, my_path + "/..")

LOG = logging.getLogger(__name__)


Expand Down