fix: unexpected sys.path injection #2076
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2076 +/- ##
===========================================
+ Coverage 93.58% 93.92% +0.34%
===========================================
Files 90 92 +2
Lines 6124 6273 +149
Branches 1260 1278 +18
===========================================
+ Hits 5731 5892 +161
+ Misses 183 175 -8
+ Partials 210 206 -4
Continue to review full report at Codecov.
|
| SimpleAccountPercentileDialup, | ||
| ) | ||
|
|
||
| my_path = os.path.dirname(os.path.abspath(__file__)) |
There was a problem hiding this comment.
@c2tarun I believe you where the original author of Feature Toggle. Why was this developed in this way? If we remove this, are there any downstream side effects? I assume this was done for a reason, just not sure what it was.
There was a problem hiding this comment.
As discussed offline, this is so that we can reference this config file from sam-translate script for testing.
There was a problem hiding this comment.
If this is just for the script, I would rather break that than do patching like this in the lib. We shouldn't need FeatureToggle from that script anyways. Maybe I am missing something but I would error on not overriding sys.path as it's super dangerous.
|
Closing in favor of #2380 |
Issue #, if available:
#1911
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.