feat: AthenaQueryPolicy template #1137
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1137 +/- ##
========================================
Coverage 94.33% 94.33%
========================================
Files 72 72
Lines 3725 3725
Branches 733 733
========================================
Hits 3514 3514
Misses 107 107
Partials 104 104Continue to review full report at Codecov.
|
There was a problem hiding this comment.
verified these policies from link: https://docs.aws.amazon.com/athena/latest/APIReference/API_Operations.html
There was a problem hiding this comment.
@nheijmans looking at this AWS docs there are more permissions required for accessing a specified athena workgroup - https://docs.aws.amazon.com/athena/latest/ug/example-policies-workgroup.html
Could you add those as well?
There was a problem hiding this comment.
@praneetap Yep I'll add them as well!
|
@nheijmans Thank you for contributing this feature!! |
Added in PR #1158! |
|
@nheijmans I added test cases for this and also resolved the merge conflicts. This PR looks good to me |
|
@nheijmans The tests need to be updated as well, the build is failing currently. Once you fix that it should be ready to go :) |
How can I do that? Can't find this in GitHub :( Sorry for replying late, was on leave... |
Added a template where a Athena workgroup can be queried and the results retrieved. By default the workgroup "primary" will be used but with the parameter a user can change it to the desired workgroup
Added the template policy for Athena to execute queries on a workgroup. Workgroup can be named with the parameter
Added the additional access needed as per referenced document https://docs.aws.amazon.com/athena/latest/ug/example-policies-workgroup.html#example1-full-access-all-wkgs excluding the deletion part which I think is a bit much for SAM
|
Rebased and fixed the tests 👍 |
Issue #, if available:
#1136
Description of changes:
Added the policy for Athena to the policy_template.json file
Description of how you validated changes:
Added the suggested code to the local file and checked with a workgroup if access was granted and queries could be executed.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.