Skip to content

Conversation

53ningen
Copy link
Contributor

Issue #, if available:
#884

Description of changes:
Add validation to AWS::Serverless::SimpleTable to make sure Name and Type exists as a property of PrimaryKey

Description of how you validated changes:
Added tests

Checklist:

  • Write/update tests
  • make pr passes
  • [-] Update documentation
  • [-] Verify transformed template deploys and application functions as expected
  • [-] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Type: AWS::Serverless::SimpleTable
Properties:
PrimaryKey:
Id: id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #1054 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1054      +/-   ##
===========================================
+ Coverage    94.91%   94.92%   +<.01%     
===========================================
  Files           69       69              
  Lines         3248     3250       +2     
  Branches       631      632       +1     
===========================================
+ Hits          3083     3085       +2     
  Misses          87       87              
  Partials        78       78
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 95.65% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c5fc7...02fa4d1. Read the comment docs.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks so much for fixing this!

@jlhood jlhood merged commit 8804733 into aws:develop Jul 30, 2019
@53ningen 53ningen deleted the bugfix/missing-required-keys branch July 31, 2019 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants