fix: make sure Name and Type exists as a property of PrimaryKey of SimpleTable (#1054)

Author: 53ningen

samtranslator/model/sam_resources.py

@@ -537,6 +537,11 @@ def _construct_dynamodb_table(self):
         dynamodb_table = DynamoDBTable(self.logical_id, depends_on=self.depends_on, attributes=self.resource_attributes)
 
         if self.PrimaryKey:
+            if 'Name' not in self.PrimaryKey or 'Type' not in self.PrimaryKey:
+                raise InvalidResourceException(
+                    self.logical_id,
+                    '\'PrimaryKey\' is missing required Property \'Name\' or \'Type\'.'
+                )
             primary_key = {
                 'AttributeName': self.PrimaryKey['Name'],
                 'AttributeType': self._convert_attribute_type(self.PrimaryKey['Type'])

tests/translator/input/error_table_primary_key_missing_name.yaml

@@ -0,0 +1,7 @@
+Resources:
+  Table:
+    Type: AWS::Serverless::SimpleTable
+    Properties:
+      PrimaryKey:
+        Id: id
+        Type: String

tests/translator/input/error_table_primary_key_missing_type.yaml

@@ -0,0 +1,6 @@
+Resources:
+  Table:
+    Type: AWS::Serverless::SimpleTable
+    Properties:
+      PrimaryKey:
+        Name: id

tests/translator/output/error_table_primary_key_missing_name.json

@@ -0,0 +1,8 @@
+{
+  "errors": [
+    {
+      "errorMessage": "Resource with id [Table] is invalid. 'PrimaryKey' is missing required Property 'Name' or 'Type'."
+    }
+  ], 
+  "errorMessage": "Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [Table] is invalid. 'PrimaryKey' is missing required Property 'Name' or 'Type'."
+}

tests/translator/output/error_table_primary_key_missing_type.json

@@ -0,0 +1,8 @@
+{
+  "errors": [
+    {
+      "errorMessage": "Resource with id [Table] is invalid. 'PrimaryKey' is missing required Property 'Name' or 'Type'."
+    }
+  ], 
+  "errorMessage": "Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [Table] is invalid. 'PrimaryKey' is missing required Property 'Name' or 'Type'."
+}

tests/translator/test_translator.py

@@ -457,6 +457,8 @@ def _generate_new_deployment_hash(self, logical_id, dict_to_hash, rest_api_to_sw
     'error_multiple_resource_errors',
     'error_s3_not_in_template',
     'error_table_invalid_attributetype',
+    'error_table_primary_key_missing_name',
+    'error_table_primary_key_missing_type',
     'error_invalid_resource_parameters',
     'error_reserved_sam_tag',
     'existing_event_logical_id',