Skip to content

Conversation

@NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Feb 5, 2020

see CHANGELOG


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

skinny85 and others added 25 commits January 22, 2020 15:52
The Java runtime for jsii used to not be able to necessarily hold the
type information necessary to correctly process the contents of
collections, as the generic information is lost.

In order to address this, introduced a new `NativeType<T>` class that is
able to carry:
1. The actual declared type of the value (via generic type parameter)
2. The raw type of the value (reified)
3. The correct JavaType to pass to Jackson to obtain the correct result

It also preserves the specific behavior around de-serialization of
`JsiiObject` sub-classes as well as jsii interfaces, correctly
requesting de-serialization as the `JsiiObject` class, and in a second
phase `transform` this into the correct value type as needed.

Introduced a new test that validates the `List<T>` and `Map<String, T>`
values received from `node` are deserialized to instances with the
appropriate content type.

Fixes #1196
In order to ensure backwards-compatibility against previously generated
assemblies, add a test that validates a random assembly generated by
some semi-arbitrary version of `jsii` (in this case,
`@aws-cdk/aws-ecs-patterns` about version `1.22.0`).

Fixes #1190

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* feat(java): annotate nullability

This commit annotates values (parameters, properties, and method return
values) with the JetBrains annotations associated to the use-case.

Implements aws/aws-cdk#6026

* de-duplicate code
This produces more comprehensive metadata on the image and
clearly identifies a maintainer.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

See CHANGELOG
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't do it better myself.

@NetaNir NetaNir merged commit 14afdde into release Feb 6, 2020
@NetaNir NetaNir deleted the neta branch February 6, 2020 00:59
mergify bot pushed a commit that referenced this pull request Sep 5, 2025
…/packages/jsii-pacmak/lib/targets/python (#4908)

Updates the requirements on [twine](https://github.com/pypa/twine) to permit the latest version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/pypa/twine/blob/main/docs/changelog.rst">twine's changelog</a>.</em></p>
<blockquote>
<h2>twine 6.2.0 (2025-09-04)</h2>
<p>Features
^^^^^^^^</p>
<ul>
<li>
<p>Automatically refresh short-lived PyPI token in long running Trusted
Publishing uploads.</p>
<p>In the event that a trusted publishing upload job is taking longer than the
validity period of a trusted publishing token (15 minutes at the time of this
writing), <em>and</em> we are already 10 minutes into that validity period, we will
begin to attempt to replace the token on each subsequent request. (<code>[#1246](pypa/twine#1246) &lt;https://github.com/pypa/twine/issues/1246&gt;</code>_)</p>
</li>
</ul>
<p>Bugfixes
^^^^^^^^</p>
<ul>
<li>Fix compatibility kludge for invalid License-File metadata entries emitted by
build backends to work also with <code>packaging</code> version 24.0. (<code>[#1217](pypa/twine#1217) &lt;https://github.com/pypa/twine/issues/1217&gt;</code>_)</li>
<li>Fix a couple of incorrectly rendered error messages. (<code>[#1224](pypa/twine#1224) &lt;https://github.com/pypa/twine/issues/1224&gt;</code>_)</li>
<li><code>twine</code> now enforces <code>keyring &gt;= 21.2.0</code>, which was previously
implicitly required by API usage. (<code>[#1229](pypa/twine#1229) &lt;https://github.com/pypa/twine/issues/1229&gt;</code>_)</li>
<li><code>twine</code> now catches <code>configparser.Error</code> to prevent accidental
leaks of secret tokens or passwords to the user's console. (<code>[#1240](pypa/twine#1240) &lt;https://github.com/pypa/twine/issues/1240&gt;</code>_)</li>
</ul>
<p>Deprecations and Removals
^^^^^^^^^^^^^^^^^^^^^^^^^</p>
<ul>
<li>
<p>Remove hacks that support <code>--skip-existing</code> for indexes other than PyPI and
TestPyPI.</p>
<p>To date, these hacks continue to accrue and there have been numerous issues
with them, not the least of which being that every time we update them, the
paid index providers change things to break the compatibility we implement
for them. Beyond that, these hacks do not work when text is internationalized
in the response from the index provider.</p>
<p>For a sample of past issues, see:</p>
<ul>
<li>
<p><a href="https://redirect.github.com/pypa/twine/issues/1251">pypa/twine#1251</a></p>
</li>
<li>
<p><a href="https://redirect.github.com/pypa/twine/issues/918">pypa/twine#918</a></p>
</li>
<li>
<p><a href="https://redirect.github.com/pypa/twine/issues/856">pypa/twine#856</a></p>
</li>
<li>
<p><a href="https://redirect.github.com/pypa/twine/issues/693">pypa/twine#693</a></p>
</li>
<li>
<p><a href="https://redirect.github.com/pypa/twine/issues/332">pypa/twine#332</a> (<code>[#1251](pypa/twine#1251) &lt;https://github.com/pypa/twine/issues/1251&gt;</code>_)</p>
</li>
</ul>
</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/pypa/twine/commit/14ceb29585a54f679e415b351aece2acc19aa4b2"><code>14ceb29</code></a> Update changelog for 6.2.0 (<a href="https://redirect.github.com/pypa/twine/issues/1264">#1264</a>)</li>
<li><a href="https://github.com/pypa/twine/commit/60e377bd5b340b90504c9e4e976eae926d9c9ddc"><code>60e377b</code></a> build(deps): bump actions/checkout from 4.2.2 to 5.0.0 (<a href="https://redirect.github.com/pypa/twine/issues/1263">#1263</a>)</li>
<li><a href="https://github.com/pypa/twine/commit/88821f278022011496c0ccb0d8ae40ab9d6c5c3d"><code>88821f2</code></a> feat(package): remove MD5 hashing entirely (<a href="https://redirect.github.com/pypa/twine/issues/1262">#1262</a>)</li>
<li><a href="https://github.com/pypa/twine/commit/ce5fe530511c13816e51dbbd13892f10274a87b1"><code>ce5fe53</code></a> build(deps): bump actions/download-artifact from 4.3.0 to 5.0.0</li>
<li><a href="https://github.com/pypa/twine/commit/6a696edefec47e842d11de468caf6c7e69694976"><code>6a696ed</code></a> PEP 639 compliance</li>
<li><a href="https://github.com/pypa/twine/commit/91753343daa1366711a441b4a13bd1b31146909b"><code>9175334</code></a> rename 1247.misc.rst to changelog/1247.misc.rst</li>
<li><a href="https://github.com/pypa/twine/commit/d94a4750883dc7cc92b2cbbb3970895303af216d"><code>d94a475</code></a> fix(tests): update expected error message</li>
<li><a href="https://github.com/pypa/twine/commit/c1c02d13d00f496339a86cd4f40d9f7e6926c0e4"><code>c1c02d1</code></a> Remove --skip-existing support for non-PyPI indices</li>
<li><a href="https://github.com/pypa/twine/commit/a24d308bb7fa5304ede3414747a939c7929d4c76"><code>a24d308</code></a> Set trusted publishing logging to INFO/WARN (<a href="https://redirect.github.com/pypa/twine/issues/1247">#1247</a>)</li>
<li><a href="https://github.com/pypa/twine/commit/becf1a8ffe6ebd404aea9d7aeae1f756aeba57ba"><code>becf1a8</code></a> Fix py3.9 mypy error in <code>__init__</code> around <code>PackageMetadata</code></li>
<li>Additional commits viewable in <a href="https://github.com/pypa/twine/compare/6.1.0...6.2.0">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants