feat(java): annotate nullability #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit annotates values (parameters, properties, and method return values) with the JetBrains annotations associated to the use-case. Implements aws/aws-cdk#6026
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
added
contribution/core
eladb
approved these changes
Feb 3, 2020
Contributor
|
Minor comments, added do-not-merge |
RomainMuller
removed
the
pr/do-not-merge
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit annotates values (parameters, properties, and method return
values) with the JetBrains annotations associated to the use-case:
@org.jetbrains.annotations.NotNull@org.jetbrains.annotations.NullableWhile there is no standard nullability annotation in the Java Language Specification,
several alternatives exist - including JSR-305
and FindBugs.
The decision to use JetBrains' is based on the following reasoning:
This can help IDEs provide static analysis of the code for discovery
of possible bugs; and will make usage from Kotlin nicer as it enables
use of the correct platform types.
Implements aws/aws-cdk#6026
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.