Skip to content

[Develop] Add support for CGK region #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Develop] Add support for CGK region #6365

merged 1 commit into from
Jul 23, 2024
+8 −6

Conversation

@hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Jul 23, 2024

Description of changes

  • Add support for CGK region in common.jinja and supported-regions
  • Distribute the tests taking into account the new region
  • Update the CHANGELOG.MD

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 added the 3.x label Jul 23, 2024
@hehe7318 hehe7318 self-assigned this Jul 23, 2024
@hehe7318 hehe7318 requested review from a team as code owners July 23, 2024 19:39
@hehe7318 hehe7318 changed the title [Develop] Add support for CGK region. [Develop] Add support for CGK region Jul 23, 2024
@hehe7318 hehe7318 force-pushed the wip/add-cgk-to-support-regions branch from 85f67df to 61d98ed Compare July 23, 2024 19:45
@hehe7318 hehe7318 merged commit fac752f into aws:develop Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hanwen-pcluste hanwen-pcluste hanwen-pcluste approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hehe7318 hehe7318

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hehe7318 @hanwen-pcluste