Skip to content

[Develop] Add support for CGK region #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Develop] Add support for CGK region #6365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CHANGELOG

- Add support for custom actions on login nodes.
- Allow DCV connection on login nodes.
- Add support for ap-southeast-3 region.

**BUG FIXES**
- Fix validator `EfaPlacementGroupValidator` so that it does not suggest to configure a Placement Group when Capacity Blocks are used.
Expand Down
3 changes: 2 additions & 1 deletion cli/src/pcluster/resources/supported-regions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ ap-northeast-2
ap-south-1
ap-southeast-1
ap-southeast-2
ap-southeast-3
ca-central-1
cn-north-1
cn-northwest-1
Expand All @@ -24,4 +25,4 @@ us-isob-east-1
us-gov-east-1
us-gov-west-1
us-west-1
us-west-2
us-west-2
2 changes: 1 addition & 1 deletion tests/integration-tests/configs/common.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- set REGIONS_COMMERCIAL = ["us-east-1", "us-east-2", "us-west-1", "us-west-2", "ca-central-1", "eu-central-1", "eu-west-1", "eu-west-2", "eu-west-3", "sa-east-1", "ap-east-1", "ap-northeast-1", "ap-northeast-2", "ap-south-1", "ap-southeast-1", "ap-southeast-2", "eu-north-1", "me-south-1", "af-south-1", "eu-south-1", "il-central-1"] -%}
{%- set REGIONS_COMMERCIAL = ["us-east-1", "us-east-2", "us-west-1", "us-west-2", "ca-central-1", "eu-central-1", "eu-west-1", "eu-west-2", "eu-west-3", "sa-east-1", "ap-east-1", "ap-northeast-1", "ap-northeast-2", "ap-south-1", "ap-southeast-1", "ap-southeast-2", "ap-southeast-3", "eu-north-1", "me-south-1", "af-south-1", "eu-south-1", "il-central-1"] -%}
{%- set REGIONS_CHINA = ["cn-north-1", "cn-northwest-1"] -%}
{%- set REGIONS_GOVCLOUD = ["us-gov-west-1", "us-gov-east-1"] -%}
{%- set REGIONS_ALL = REGIONS_COMMERCIAL + REGIONS_CHINA + REGIONS_GOVCLOUD -%}
Expand Down
8 changes: 4 additions & 4 deletions tests/integration-tests/configs/develop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ test-suites:
schedulers: ["slurm"]
test_security_groups.py::test_overwrite_sg:
dimensions:
- regions: ["eu-north-1"]
- regions: ["ap-southeast-3"]
instances: {{ common.INSTANCES_DEFAULT_X86 }}
oss: ["rocky9"]
schedulers: ["slurm"]
Expand All @@ -401,7 +401,7 @@ test-suites:
scaling:
test_scaling.py::test_job_level_scaling:
dimensions:
- regions: ["us-west-2"]
- regions: ["ap-southeast-3"]
instances: {{ common.INSTANCES_DEFAULT_ARM }}
oss: ["ubuntu2204"]
schedulers: ["slurm"]
Expand Down Expand Up @@ -446,7 +446,7 @@ test-suites:
schedulers: [ "slurm" ]
test_slurm.py::test_error_handling:
dimensions:
- regions: ["ca-central-1"]
- regions: ["ap-southeast-3"]
instances: {{ common.INSTANCES_DEFAULT_X86 }}
oss: ["rocky9"]
schedulers: ["slurm"]
Expand Down Expand Up @@ -512,7 +512,7 @@ test-suites:
schedulers: ["slurm"]
test_slurm.py::test_slurm_custom_config_parameters:
dimensions:
- regions: ["ap-northeast-2"]
- regions: ["ap-southeast-3"]
instances: {{ common.INSTANCES_DEFAULT_X86 }}
oss: ["ubuntu2004"]
schedulers: ["slurm"]
Expand Down