Skip to content

Conversation

@davprat
Copy link
Contributor

@davprat davprat commented Sep 9, 2022

Description of changes

  • Updated EFA integration test to refer to /usr/local/cuda linked directory rather than /usr/local/cuda-11.4
  • This is so that the test will work with newer versions of CUDA.
  • Additional change to upload_artifacts.sh shell script to support both BSD (MacOS) and Linux style sed options.
  • -i requires an argument on Mac - changed so that integration tests could be run from developer Macs.

Tests

  • Ran EFA integration test from developer desktop on developer account.
  • EFA integration test was modified to CUDA version agnostic.

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davprat davprat added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #4331 (127a9bb) into develop (9f04907) will not change coverage.
The diff coverage is n/a.

❗ Current head 127a9bb differs from pull request most recent head 99de6e3. Consider uploading reports for the commit 99de6e3 to get more accurate results

@@           Coverage Diff            @@
##           develop    #4331   +/-   ##
========================================
  Coverage    88.60%   88.60%           
========================================
  Files          158      158           
  Lines        13479    13479           
========================================
  Hits         11943    11943           
  Misses        1536     1536           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@davprat davprat marked this pull request as ready for review September 9, 2022 23:38
@davprat davprat requested review from a team as code owners September 9, 2022 23:38
@davprat davprat force-pushed the cuda-test branch 2 times, most recently from 1a6fca1 to 627f4c6 Compare September 16, 2022 02:07

BUILD_OS=$(uname)
if [ "${BUILD_OS}" != "Linux" ]; then
SED_BAK_EXT="''"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik the safest approach to reuse the same sed parameters both in Linux and Mac is to use gsed instead of sed on Mac.
Btw, no problem at all with this approach as far as it's working on our specific case.
Thanks for proposing it: I did not know about it.

@davprat davprat merged commit e8f3c5d into aws:develop Sep 26, 2022
@davprat davprat deleted the cuda-test branch October 4, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants