Skip to content

Conversation

@davprat
Copy link
Contributor

@davprat davprat commented Sep 12, 2022

Description of changes

  • Upgraded NVIDA CUDA Toolkit to version 11.7.1 in response to CVE

Tests

  • Modified integration test to be CUDA version agnostic.
  • Modified AMI validation test to support new separate samples package on ARM architecture.

References

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davprat davprat added dependencies Pull requests that update a dependency file 3.x labels Sep 12, 2022
@davprat davprat force-pushed the PCLUSTER-5187 branch 2 times, most recently from b18f290 to 19ed4f7 Compare September 14, 2022 16:24
@davprat davprat marked this pull request as ready for review September 14, 2022 21:54
@davprat davprat requested review from a team as code owners September 14, 2022 21:54
default['cluster']['nvidia']['driver_url'] = "https://us.download.nvidia.com/tesla/#{node['cluster']['nvidia']['driver_version']}/NVIDIA-Linux-#{node['cluster']['nvidia']['driver_url_architecture_id']}-#{node['cluster']['nvidia']['driver_version']}.run"
default['cluster']['nvidia']['cuda_url'] = "https://developer.download.nvidia.com/compute/cuda/11.4.4/local_installers/cuda_11.4.4_470.82.01_#{node['cluster']['nvidia']['cuda_url_architecture_id']}.run"
default['cluster']['nvidia']['cuda_url'] = "https://developer.download.nvidia.com/compute/cuda/11.7.1/local_installers/cuda_11.7.1_515.65.01_#{node['cluster']['nvidia']['cuda_url_architecture_id']}.run"
default['cluster']['nvidia']['sample_url'] = "https://github.com/NVIDIA/cuda-samples/archive/refs/tags/v#{node['cluster']['nvidia']['cuda_sample_version']}.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main goal of this PR seems to be the upgrade to CUDA 11.7.1. Why should we include NVIDIA Samples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The samples contain a utility that we use to validate the installation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it thanks

@davprat davprat force-pushed the PCLUSTER-5187 branch 4 times, most recently from 5a824f6 to ea36c27 Compare September 26, 2022 20:46
@davprat davprat merged commit cb63b87 into aws:develop Sep 27, 2022
@davprat davprat deleted the PCLUSTER-5187 branch November 15, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants