Remove bespoke Prometheus helm chart and use the latest public release instead #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This more or less reverts #294.
The prior version of the Prometheus was
19.1.0. I am pinning the new version to41.7.4, the latest release as of today, because it works and should let us have stable tests into the future.Besides simplifying our ongoing maintenance, this will also serve to make deprecating
PodSecurityPolicyeasier (#638), because this helm chart has quite a few PodSecurityPolicies in it.Testing:
I verified the Prometheus test before and after this change by comparing the test output. The test still passes with the newer, unmodified release of Prometheus.
This is the command to run just the Prometheus end-to-end test:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.