Skip to content

add prometheus helm chart for e2e tests #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

add prometheus helm chart for e2e tests #294

merged 1 commit into from
Nov 18, 2020

Conversation

brycahta
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Moved chart from old helm repo and took out what wasn't necessary to get tests passing

Testing:

  • make e2e-test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from bwagner5 November 17, 2020 21:04
bwagner5
bwagner5 approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brycahta brycahta merged commit 0d8f612 into aws:main Nov 18, 2020
@brycahta brycahta deleted the fix-helm branch November 18, 2020 14:06
snay2 added a commit to snay2/aws-node-termination-handler that referenced this pull request Nov 11, 2022
@snay2
Remove bespoke Prometheus helm chart and use the latest public releas…
ce5692c 
…e instead

This more or less reverts aws#294.
Besides simplifying our ongoing maintenance, this will also serve to make deprecating PodSecurityPolicy easier (aws#638)
snay2 added a commit to snay2/aws-node-termination-handler that referenced this pull request Nov 11, 2022
@snay2
Remove bespoke Prometheus helm chart and use the latest public releas…
3c9792c 
…e instead

This more or less reverts aws#294.
Besides simplifying our ongoing maintenance, this will also serve to make deprecating PodSecurityPolicy easier (aws#638)
@snay2 snay2 mentioned this pull request Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brycahta @bwagner5