-
Notifications
You must be signed in to change notification settings - Fork 381
Use release-plz for automated releases #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Release-plz | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| release-plz-release: | ||
| name: Release-plz release | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository_owner == 'aws' }} | ||
| permissions: | ||
| contents: write | ||
| id-token: write | ||
| steps: | ||
| - &checkout | ||
| name: Checkout repository | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: true | ||
| token: ${{ secrets.RELEASE_PLZ_TOKEN }} | ||
| - &install-rust | ||
| name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable | ||
| - name: Run release-plz | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I highly recommend integrating with trusted publishing as part of this PR, which lets you do: |
||
| uses: release-plz/[email protected] | ||
| with: | ||
| command: release | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.RELEASE_PLZ_TOKEN }} | ||
|
|
||
| release-plz-pr: | ||
| name: Release-plz PR | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository_owner == 'aws' }} | ||
| permissions: | ||
| pull-requests: write | ||
| contents: write | ||
| concurrency: | ||
| group: release-plz-${{ github.ref }} | ||
| cancel-in-progress: false | ||
| steps: | ||
| - *checkout | ||
| - *install-rust | ||
| - name: Run release-plz | ||
| uses: release-plz/[email protected] | ||
| with: | ||
| command: release-pr | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.RELEASE_PLZ_TOKEN }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [workspace] | ||
| semver_check = true | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably redundant since we already have cargo-semver-check CI, but harmless
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intended to have it explicit 👍🏻 |
||
| git_release_enable = false | ||
|
|
||
| [[package]] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if this will work, I think we would need positive statements for our packages if our workspace has it set to false? Alternative example: But worst case we can always give it a shot and fix if it doesn't work, low stakes. |
||
| name = "lambda-integration-tests" | ||
| publish = false | ||
|
|
||
| [changelog] | ||
| protect_breaking_commits = true | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't need the token on this step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autogenerated by release-plz 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that once you enable using a personal access token it sets it automatically without even though it's not needed.