-
Notifications
You must be signed in to change notification settings - Fork 380
Use release-plz for automated releases #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/release-plz.yml
Outdated
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: true | ||
| token: ${{ secrets.RELEASE_PLZ_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't need the token on this step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autogenerated by release-plz 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that once you enable using a personal access token it sets it automatically without even though it's not needed.
| - &install-rust | ||
| name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable | ||
| - name: Run release-plz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I highly recommend integrating with trusted publishing as part of this PR, which lets you do:
- name: Authenticate to crates.io
uses: rust-lang/crates-io-auth-action@v1
id: auth
- name: Run release-plz
uses: release-plz/[email protected]
with:
command: release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CARGO_REGISTRY_TOKEN: ${{ steps.auth.outputs.token }}
| semver_check = true | ||
| git_release_enable = false | ||
|
|
||
| [[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will work, I think we would need positive statements for our packages if our workspace has it set to false?
Alternative example:
[[package]]
name = "metrique"
changelog_include = [
"metrique-core",
"metrique-macro",
"metrique-metricsrs",
"metrique-service-metrics",
"metrique-timesource",
"metrique-writer",
"metrique-writer-core",
"metrique-writer-format-emf",
"metrique-writer-macro"
]
changelog_path = "./CHANGELOG.md"
git_release_enable = true
But worst case we can always give it a shot and fix if it doesn't work, low stakes.
| @@ -0,0 +1,10 @@ | |||
| [workspace] | |||
| semver_check = true | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably redundant since we already have cargo-semver-check CI, but harmless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intended to have it explicit 👍🏻
📬 Issue #, if available:
✍️ Description of changes:
🔏 By submitting this pull request
cargo +nightly fmt.cargo clippy --fix.