fix: "Invalid Assembly Manifest" when used with CLI 2.1017.0 and 2.1018.0 #34880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Jul 2, 2025
rix0rrr
added a commit
to aws/aws-cdk-cli
that referenced
this pull request
Jul 2, 2025
I did not want to bump the version number previously because the CLI did not yet *act* on the new definitions found inside the schema, and users would get the error message: ``` This CDK CLI is not compatible with the CDK library used by your application. Please upgrade the CLI to the latest version. ``` For no benefit. This was a mistake, because we use `jsonschema` to validate the contents of the manifest file and now old versions of the CLI try and validate new files using the old schema, and instead they get the error: ``` Invalid assembly manifest: instance.artifacts.aws-cdk-lib/feature-flag-report.type is not one of enum values: none,aws:cloudformation:stack,cdk:tree,cdk:asset-manifest,cdk:cloud-assembly instance.artifacts.aws-cdk-lib/feature-flag-report.properties requires property "templateFile" instance.artifacts.aws-cdk-lib/feature-flag-report.properties requires property "file" ``` We will need another mechanism to achieve the goal of not requiring people to upgrade their CLI unnecessarily; holding back the version number is just exchanging one error message for a worse one. Belatedly bump the version number here, so that we can release this and reapply this change: aws/aws-cdk#34880
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
approved these changes
Jul 2, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-cdk-lib2.203.0 gives an incorrect error message when used with AWS CLI 2.2017.0 and 2.2018.0. The error message should have been:Instead, the error message is:
This reverts the change that introduces that new artifact type: #34798