fix(cloud-assembly-schema): bump the version number #677
Conversation
I did not want to bump the version number previously because the CLI did not yet *act* on the new definitions found inside the schema, and users would get the error message: ``` This CDK CLI is not compatible with the CDK library used by your application. Please upgrade the CLI to the latest version. ``` For no benefit. This was a mistake, because we use `jsonschema` to validate the contents of the manifest file and now old versions of the CLI try and validate new files using the old schema, and instead they get the error: ``` Invalid assembly manifest: instance.artifacts.aws-cdk-lib/feature-flag-report.type is not one of enum values: none,aws:cloudformation:stack,cdk:tree,cdk:asset-manifest,cdk:cloud-assembly instance.artifacts.aws-cdk-lib/feature-flag-report.properties requires property "templateFile" instance.artifacts.aws-cdk-lib/feature-flag-report.properties requires property "file" ``` We will need another mechanism to achieve the goal of not requiring people to upgrade their CLI unnecessarily; holding back the version number is just exchanging one error message for a worse one. Belatedly bump the version number here, so that we can release this and reapply this change: aws/aws-cdk#34880
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 46 46
Lines 7102 7102
Branches 794 794
=======================================
Hits 5607 5607
Misses 1476 1476
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you please release cdk-assets? Right now with the latest 4.0.1 version we can't deploy schema 45.0.0 |
same issue i am facing while deploying pipeline getting error like : Error: Cannot read asset manifest 'assembly-ckeditorPipeline-Deploy-dev-us-west-2/ckeditorPipelineDeploydevuswest2CKeditorStack72A7D191.assets.json': Cloud assembly schema version mismatch: Maximum schema version supported is 44.x.x, but found 45.0.0 |
|
error with cdk assembly versions |
6 participants
I did not want to bump the version number previously because the CLI did not yet act on the new definitions found inside the schema, and users would get the error message:
For no benefit.
This was a mistake, because we use
jsonschemato validate the contents of the manifest file and now old versions of the CLI try and validate new files using the old schema, and instead they get the error:We will need another mechanism to achieve the goal of not requiring people to upgrade their CLI unnecessarily; holding back the version number is just exchanging one error message for a worse one.
Belatedly bump the version number here, so that we can release this and reapply this change: aws/aws-cdk#34880
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license