Skip to content

Conversation

@jinxiao
Copy link
Contributor

@jinxiao jinxiao commented Nov 27, 2025

Summary

Changes

Change the ARN of China cn-north-1 region, this typo makes our users too confusing, and we want to change it to correct one.

Current: arn:aws-aws-cn:lambda:cn-north-1:498634801083:layer:AWSLambdaPowertoolsTypeScriptV2:41

Correct: arn:aws-cn:lambda:cn-north-1:498634801083:layer:AWSLambdaPowertoolsTypeScriptV2:41

The partition should be aws-cn rather than aws-aws-cn

Issue number: fix #4819


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 27, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Nov 27, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Nov 27, 2025
dreamorosi
dreamorosi previously approved these changes Nov 27, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR and fixing this!

@svozza
Copy link
Contributor

svozza commented Nov 27, 2025

Hi there. Thank you for the fix! It looks like the linter is failing in the CI tests:

markdownlint-cli2 v0.19.1 (markdownlint v0.39.0)
Finding: /*.md !node_modules !//node_modules !docs/changelog.md !LICENSE.md !.github !CHANGELOG.md !**//CHANGELOG.md !examples/app/README.md !.venv !site
Linting: 49 file(s)
Summary: 1 error(s)
docs/getting-started/lambda-layers.md:56:125 error MD060/table-column-style Table column style [Table pipe does not align with heading for style "aligned"]
Error: Process completed with exit code 1.

Can you have a look @jinxiao? You can run the linter locally by doing npm run lint:markdown.

@sonarqubecloud
Copy link

@svozza svozza merged commit 3812104 into aws-powertools:main Nov 27, 2025
46 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 27, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@svozza
Copy link
Contributor

svozza commented Nov 27, 2025

Thank you @jinxiao, now merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS PR between 0-9 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Change China Region ARN to Correct One

3 participants