added zero-events on untriggered codes #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbingli
approved these changes
Aug 21, 2020
wbingli
reviewed
Aug 21, 2020
| .forEach(errorCode -> this.metricsPublisherProxy.publishExceptionByErrorCodeMetric(Instant.now(), action, | ||
| errorCode, thrown)); | ||
| EnumSet.allOf(HandlerErrorCode.class).forEach(errorCode -> this.metricsPublisherProxy | ||
| .publishExceptionByErrorCodeMetric(Instant.now(), action, errorCode, thrown && errorCode == handlerErrorCode)); |
There was a problem hiding this comment.
We should publish all those ErrorCode metrics in one PutMetric call, which can support multiple metrics in one request.. Otherwise it will consume large number of TPS, and may cause throttling.
xiwhuang
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
a follow up for the previous pr #298 => adding 0 values for the codes that did not cause exception
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.