-
Notifications
You must be signed in to change notification settings - Fork 48
additional cw-metrics #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ammokhov
merged 3 commits into
aws-cloudformation:master
from
ammokhov:metrics-dashboard
Aug 21, 2020
Merged
additional cw-metrics #298
ammokhov
merged 3 commits into
aws-cloudformation:master
from
ammokhov:metrics-dashboard
Aug 21, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemengi
reviewed
Aug 18, 2020
src/main/java/software/amazon/cloudformation/LambdaWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/LambdaWrapper.java
Outdated
Show resolved
Hide resolved
6c97349 to
62d3e8b
Compare
clemengi
approved these changes
Aug 19, 2020
sungkkim
approved these changes
Aug 19, 2020
xiwhuang
approved these changes
Aug 20, 2020
wbingli
reviewed
Aug 20, 2020
src/main/java/software/amazon/cloudformation/metrics/MetricsPublisherImpl.java
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/metrics/MetricsPublisherImpl.java
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/LambdaWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/LambdaWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/LambdaWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/LambdaWrapper.java
Outdated
Show resolved
Hide resolved
wbingli
reviewed
Aug 20, 2020
wbingli
suggested changes
Aug 21, 2020
| if (this.metricsPublisherProxy != null) { | ||
| EnumSet.allOf(HandlerErrorCode.class).stream() | ||
| // publishing 0 value for all (if not thrown) otherwise filtered | ||
| .filter(errorCode -> errorCode.equals(handlerErrorCode) || !thrown) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed. We actually want to do forEach for all ErrorCode, not match in what cases.
In case of in a Failed cases, this will only emit metric 1 for the one equals to the ErrorCode, but won't emit 0 metric for other metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #297
Description of changes:
Added some extra metrics so to create cw alarms upon.
Metric No. 1
Metric No. 2 - not added: the reason being is that operation status for uncaught exceptions is always
FAILED, so this metrics seems to be redundant; we have enough of the exact same information in other dimensions;Metric No. 3
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.