Skip to content

Conversation

@ammokhov
Copy link
Contributor

Issue #, if available: #297

Description of changes:

Added some extra metrics so to create cw alarms upon.

Metric No. 1

Namespace: under resource type namespace
Metric name: "HandlerException"
Dimensions: Action, HandlerErrorCode, ResourceType 

Metric No. 2 - not added: the reason being is that operation status for uncaught exceptions is always FAILED, so this metrics seems to be redundant; we have enough of the exact same information in other dimensions;

Namespace:  <does not really matter>
Metric name: "HandlerException"
Dimensions: Action, OperationStatus, ResourceType # with OperationStatus in software.amazon.cloudformation.proxy.OperationStatus.values()

Metric No. 3

Namespace:  under resource type namespace
Metric name: "HandlerException"
Dimensions: Action, ResourceType

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammokhov ammokhov merged commit 2ca8a71 into aws-cloudformation:master Aug 21, 2020
@ammokhov ammokhov deleted the metrics-dashboard branch August 21, 2020 06:28
if (this.metricsPublisherProxy != null) {
EnumSet.allOf(HandlerErrorCode.class).stream()
// publishing 0 value for all (if not thrown) otherwise filtered
.filter(errorCode -> errorCode.equals(handlerErrorCode) || !thrown)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed. We actually want to do forEach for all ErrorCode, not match in what cases.

In case of in a Failed cases, this will only emit metric 1 for the one equals to the ErrorCode, but won't emit 0 metric for other metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish by-HandlerErrorCode, by-OperationStatus and top-level InternalFailure metrics

5 participants