Extending linter to fully support translated SAM templates #2173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2021
|
This has been handled via an upstream merge to the SAM CLI. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: aws/serverless-application-model#2224
In translated SAM templates, metadata is not currently copied to new resources. In addition, line-numbers are not updated to reflect the new template data. As a result of both concerns, it's impossible to add in-template metadata to exclude rules in cfn-lint.
This PR round-trips the transformed template so that the internal loading mechanism can apply proper line numbers. This PR additionally copies parent-resouce-metadata to child-resources that are created in the transform workflow.
Exposing the parent/child relationship is dependent on the referenced PR being merged.