Skip to content

Conversation

@kddejong
Copy link
Contributor

@kddejong kddejong commented May 21, 2021

Issue #, if available: #476
fix #2016
Description of changes:

  • Ignore failures if Fn::Transform is in the path

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong
Copy link
Contributor Author

kddejong commented May 21, 2021

In relation to #2017 (comment)


if results:
for result in results:
if 'Fn::Transform' in result.path:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we've expanded short form to long form by this point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Hmm. Shouldn't the short form be !Transform?

@kddejong
Copy link
Contributor Author

may need to add a rule attribute that will specify if we want to include Fn::Transform in the errors.

@kddejong kddejong changed the base branch from master to main June 10, 2021 18:14
@andrew-glenn
Copy link
Contributor

#2173 Is potentially related

@kddejong
Copy link
Contributor Author

Going to close this as it hasn't come up again. Code will remain just in case.

@kddejong kddejong closed this Aug 18, 2022
@kddejong kddejong deleted the fix/issue/2008-alternative branch June 27, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E7003 Errors when using Fn::Transform inside a Mapping

3 participants