Skip to content

Throwing a configuration error in the constructor if appAppleId is null/nil/undefined and the environment is Production #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderjordanbaker merged 3 commits into from
Mar 6, 2024
Merged

Throwing a configuration error in the constructor if appAppleId is null/nil/undefined and the environment is Production #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
483547a
Check required configuration if environment is production
shimastripe Feb 19, 2024
e3dc543
Update readme
shimastripe Feb 19, 2024
b2a7bc4
Fix variable type
shimastripe Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,12 @@ import AppStoreServerLibrary

let bundleId = "com.example"
let appleRootCAs = loadRootCAs() // Specific implementation may vary
let appAppleId: Int64? = nil // appAppleId must be provided for the Production environment
let enableOnlineChecks = true
let environment = Environment.sandbox

// try! used for example purposes only
let verifier = try! SignedDataVerifier(rootCertificates: appleRootCAs, bundleId: bundleId, appAppleId: nil, environment: environment, enableOnlineChecks: enableOnlineChecks)
let verifier = try! SignedDataVerifier(rootCertificates: appleRootCAs, bundleId: bundleId, appAppleId: appAppleId, environment: environment, enableOnlineChecks: enableOnlineChecks)

let notificationPayload = "ey..."
let notificationResult = await verifier.verifyAndDecodeNotification(signedPayload: notificationPayload)
Expand Down
11 changes: 10 additions & 1 deletion Sources/AppStoreServerLibrary/SignedDataVerifier.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ import Foundation

///A verifier and decoder class designed to decode signed data from the App Store.
public struct SignedDataVerifier {


public enum ConfigurationError: Error {
case INVALID_APP_APPLE_ID
}

private var bundleId: String
private var appAppleId: Int64?
private var environment: Environment
Expand All @@ -18,6 +22,11 @@ public struct SignedDataVerifier {
/// - Parameter enableOnlineChecks: Whether to enable revocation checking and check expiration using the current date
/// - Throws: When the root certificates are malformed
public init(rootCertificates: [Foundation.Data], bundleId: String, appAppleId: Int64?, environment: Environment, enableOnlineChecks: Bool) throws {

guard !(environment == .production && appAppleId == nil) else {
throw ConfigurationError.INVALID_APP_APPLE_ID
}

self.bundleId = bundleId
self.appAppleId = appAppleId
self.environment = environment
Expand Down