Throwing a configuration error in the constructor if appAppleId is null/nil/undefined and the environment is Production #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
|
|
||
| let bundleId = "com.example" | ||
| let appleRootCAs = loadRootCAs() // Specific implementation may vary | ||
| let appAppleId: String? = nil // For production environments, it's required |
Collaborator
There was a problem hiding this comment.
This is an Int64?, also could you please use the phrase "appAppleId must be provided for the Production environment"
alexanderjordanbaker
approved these changes
Mar 6, 2024
Collaborator
alexanderjordanbaker
left a comment
alexanderjordanbaker
left a comment
There was a problem hiding this comment.
LGTM, thank you for the PR and issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT