Revert "[SPARK-45088][PYTHON][CONNECT] Make getitem work with duplicated column"
#43211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated columns" This reverts commit 73d3c49.
cloud-fan
approved these changes
Oct 4, 2023
HyukjinKwon
approved these changes
Oct 4, 2023
Contributor
Author
|
thank you, merged to master |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Oct 7, 2023
…cated column" ### What changes were proposed in this pull request? This reverts commit 73d3c49. ### Why are the changes needed? to address apache#42828 (comment) and apache#43115 (comment), should not use `GetColumnByOrdinal` in this case. Need to find another approach, but let's revert it first. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#43211 from zhengruifeng/revert_SPARK_45088. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This reverts commit 73d3c49.
Why are the changes needed?
to address #42828 (comment) and #43115 (comment), should not use
GetColumnByOrdinalin this case.Need to find another approach, but let's revert it first.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No