[TEST ONLY][SQL] Test resolve column references with PLAN_ID #43115
Conversation
zhengruifeng
changed the title
…cated column" ### What changes were proposed in this pull request? This reverts commit 73d3c49. ### Why are the changes needed? to address #42828 (comment) and #43115 (comment), should not use `GetColumnByOrdinal` in this case. Need to find another approach, but let's revert it first. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No Closes #43211 from zhengruifeng/revert_SPARK_45088. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
zhengruifeng
force-pushed
the
sql_test_sql_column
branch
from
241338c to
972b5dc
Compare
There was a problem hiding this comment.
I think we can still eagerly resolve the column here to make sure it exists, then create an UnresolvedAttribute from the resolved AttributeReference: UnresolvedAttribute(Seq(attr.name)).
…cated column" ### What changes were proposed in this pull request? This reverts commit 73d3c49. ### Why are the changes needed? to address apache#42828 (comment) and apache#43115 (comment), should not use `GetColumnByOrdinal` in this case. Need to find another approach, but let's revert it first. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#43211 from zhengruifeng/revert_SPARK_45088. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
zhengruifeng
force-pushed
the
sql_test_sql_column
branch
from
972b5dc to
9d67eb5
Compare
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
@zhengruifeng can we rebase and rerun the tests? The new df col framework got several bug fixes and let's try it out again. |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
2 participants
What changes were proposed in this pull request?
#39925 introduced a new approach to resolve column references with PLAN_ID, this PR tests what will happen if we apply it in regular Spark SQL.
Why are the changes needed?
NA
Does this PR introduce any user-facing change?
NO
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
NO