Skip to content

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented May 4, 2022

What changes were proposed in this pull request?

Add missed dependencies to dev/create-release/spark-rm/Dockerfile.

Why are the changes needed?

To be able to build Spark releases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By building the Spark 3.3 release via:

$ dev/create-release/do-release-docker.sh -d /home/ubuntu/max/spark-3.3-rc1

@MaxGekk MaxGekk changed the title [WIP][SPARK-39099][BUILD] Add dependencies to Dockerfile for building Spark releases [SPARK-39099][BUILD] Add dependencies to Dockerfile for building Spark releases May 5, 2022
@MaxGekk MaxGekk marked this pull request as ready for review May 5, 2022 08:04
@MaxGekk
Copy link
Member Author

MaxGekk commented May 5, 2022

Merging to master/3.3. @cloud-fan Thank you for review.

@MaxGekk MaxGekk closed this in 4b1c2fb May 5, 2022
MaxGekk added a commit that referenced this pull request May 5, 2022
…k releases

### What changes were proposed in this pull request?
Add missed dependencies to `dev/create-release/spark-rm/Dockerfile`.

### Why are the changes needed?
To be able to build Spark releases.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
By building the Spark 3.3 release via:
```
$ dev/create-release/do-release-docker.sh -d /home/ubuntu/max/spark-3.3-rc1
```

Closes #36449 from MaxGekk/deps-Dockerfile.

Authored-by: Max Gekk <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
(cherry picked from commit 4b1c2fb)
Signed-off-by: Max Gekk <[email protected]>
@dongjoon-hyun
Copy link
Member

Thank you, @MaxGekk !
+1, late LGTM.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member

I backported this to branch-3.2 for Apache Spark 3.2.2 preparation.

dongjoon-hyun pushed a commit that referenced this pull request Jul 11, 2022
…k releases

Add missed dependencies to `dev/create-release/spark-rm/Dockerfile`.

To be able to build Spark releases.

No.

By building the Spark 3.3 release via:
```
$ dev/create-release/do-release-docker.sh -d /home/ubuntu/max/spark-3.3-rc1
```

Closes #36449 from MaxGekk/deps-Dockerfile.

Authored-by: Max Gekk <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
(cherry picked from commit 4b1c2fb)
Signed-off-by: Max Gekk <[email protected]>
(cherry picked from commit 6a61f95)
Signed-off-by: Dongjoon Hyun <[email protected]>
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
…k releases

Add missed dependencies to `dev/create-release/spark-rm/Dockerfile`.

To be able to build Spark releases.

No.

By building the Spark 3.3 release via:
```
$ dev/create-release/do-release-docker.sh -d /home/ubuntu/max/spark-3.3-rc1
```

Closes apache#36449 from MaxGekk/deps-Dockerfile.

Authored-by: Max Gekk <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
(cherry picked from commit 4b1c2fb)
Signed-off-by: Max Gekk <[email protected]>
(cherry picked from commit 6a61f95)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants