-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-34950][TESTS] Update benchmark results to the ones created by GitHub Actions machines #32044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #136883 has finished for PR 32044 at commit
|
| 2500 select expressions 211 214 4 0.0 210927791.0 0.0X | ||
| 1 select expressions 1 2 0 0.0 1296117.0 1.0X | ||
| 100 select expressions 9 11 1 0.0 8808690.0 0.1X | ||
| 2500 select expressions 422 426 5 0.0 421632363.0 0.0X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regression by 2 times?
| Select 1000 columns 96330 99161 NaN 0.0 96329.7 1.0X | ||
| Select 100 columns 41414 42672 1556 0.0 41414.1 2.3X | ||
| Select one column 35365 36113 662 0.0 35365.4 2.7X | ||
| count() 18845 18867 26 0.1 18845.0 5.1X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regression by 2 times
|
+1, LGTM. The PR updates only benchmark results. The failed GA are not related to this PR. Merging to master. |
|
@HyukjinKwon Can we use this way to generate the benchmarks results with Java 17? On the other hand, I found some benchmarks do not have corresponding Java 11 result files, such as |
Let me study #32015 first. Should all new benchmarks results need generate in this way? |
|
Yes, they all should generate the files for JDK 11. If they don't, it's a bug. Yes, we should have another set of these benchmark result files for JDK 17 separately |
|
Thank you for your explanation |
What changes were proposed in this pull request?
#32015 added a way to run benchmarks much more easily in the same GitHub Actions build. This PR updates the benchmark results by using the way.
NOTE that looks like GitHub Actions use four types of CPU given my observations:
Given my quick research, seems like they perform roughly similarly:
I couldn't find enough information about Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz but the performance seems roughly similar given the numbers.
So shouldn't be a big deal especially given that this way is much easier, encourages contributors to run more and guarantee the same number of cores and same memory with the same softwares.
Why are the changes needed?
To have a base line of the benchmarks accordingly.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
It was generated from: