Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Oct 18, 2019

Make sure you have checked all steps below. Updated the tests a bit as well. There were some conflicts between both test.thrift files. I've consolidated them to avoid issues.

Updating to Scala 2.12 is required to support Java 11.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Fokko added 2 commits October 15, 2019 10:44
This also includes updating Scrooge because it isn't compiled
anymore against Scala 2.10
@@ -1,14 +1,14 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has only style changes, would you mind reverting it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point, done!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted a couple more unrelated changes.

@Fokko Fokko force-pushed the fd-bump-scrooge branch 3 times, most recently from 956cc38 to 38c472e Compare October 18, 2019 13:02
ScroogeBinaryTest.java
ThriftParquetReader.java
@Fokko
Copy link
Contributor Author

Fokko commented Oct 23, 2019

Does someone have some spare time to review this? Would be great to move Java 11 support forward.

@Fokko Fokko requested a review from nandorKollar October 25, 2019 07:13
@Fokko
Copy link
Contributor Author

Fokko commented Oct 25, 2019

@nandorKollar Are you fine with the current PR as is? 👍

@nandorKollar
Copy link
Contributor

Sure, thanks @Fokko!

@nandorKollar nandorKollar merged commit ca7d0e2 into apache:master Oct 25, 2019
shangxinli pushed a commit to shangxinli/parquet-mr that referenced this pull request Dec 16, 2019
* PARQUET-1496: Update Scala to 2.12

This also includes updating Scrooge because it isn't compiled
anymore against Scala 2.10

* Fix the tests

* Revert unrelated changes

ScroogeBinaryTest.java
ThriftParquetReader.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants