-
Notifications
You must be signed in to change notification settings - Fork 1.5k
PARQUET-1496: Update Scala to 2.12 #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also includes updating Scrooge because it isn't compiled anymore against Scala 2.10
| @@ -1,14 +1,14 @@ | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has only style changes, would you mind reverting it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid point, done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted a couple more unrelated changes.
956cc38 to
38c472e
Compare
ScroogeBinaryTest.java ThriftParquetReader.java
38c472e to
2d81079
Compare
|
Does someone have some spare time to review this? Would be great to move Java 11 support forward. |
|
@nandorKollar Are you fine with the current PR as is? 👍 |
|
Sure, thanks @Fokko! |
* PARQUET-1496: Update Scala to 2.12 This also includes updating Scrooge because it isn't compiled anymore against Scala 2.10 * Fix the tests * Revert unrelated changes ScroogeBinaryTest.java ThriftParquetReader.java
Make sure you have checked all steps below. Updated the tests a bit as well. There were some conflicts between both
test.thriftfiles. I've consolidated them to avoid issues.Updating to Scala 2.12 is required to support Java 11.
Jira
Tests
Commits
Documentation