bump to parquet-scala to 2.12 #580
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-williams
changed the title
Contributor
|
@ryan-williams could you please open a Jira for this issue here: https://jira.apache.org/jira/projects/PARQUET/issues Also, it seems that Travis failed for the PR. I think because for some reason it runs with JDK7 (don't know why), could you please have a look at it too? With this Scala version upgrade I'm afraid that the minimum Java version will be Java 8. |
Contributor
|
Thank you @ryan-williams for opening the PR. We're in the process of moving to newer versions of Scala, and 2.10 will be dropped in the next release. I've created a PR that will solve the issues with the update of the I'll close this one, for now, hope you don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parquet-scala has only been released for Scala 2.10 (which has been EOL'd for a few years).
Scala 2.11 is almost EOL as well; Spark held a lot of the ecosystem on 2.11 but now supports 2.12.
Scala 2.13.0 will also land soon.
So, I think bumping parquet-scala directly to 2.12 makes the most sense. Additionally, it would be good to go back release 2.12 (and probably 2.11) artifacts for some of the recent releases. I'm not sure what the process would have to be for that; it's not really a new release, but rather some new artifacts that were arguably missing the first time around 😀
I've already released most of
parquet-scala_{2.11,2.12}x{1.8.3,1.10.0}under my own group ID, to address pressing needs in some downstream projects (cf. bigdatagenomics/adam#2108); the changes are fairly trivial (see below, or this equivalent patch for 2.11).One caveat is that I couldn't get any of the scrooge-core_2.12 versions working against 1.8.x (at least, not without upgrading thrift; maybe that means we could only push e.g. 1.10.0 artifacts, but not 1.8.3?). Two relevant branches:
scrooge-2.12-1.8.3-wip: some progress toward scrooge 18.12.0scrooge-2.12-1.12.0successfully builds+tests scrooge_2.12:18.12.0 against HEAD and thrift 0.11.0Maybe a more practical thing would be to leave parquet-scrooge on 2.10 for now; I don't think there's any reason it needs to be published for the same scala version as parquet-scala.