PARQUET-1497: Add javax.annotation-api dependency for JDK >= 9

[xhochy]

cc @Fokko

[Fokko]

I tried to compile it under openjdk9:

root@1c7db173d68a:/tmp/thrift-0.12.0# java --version
openjdk 9.0.4
OpenJDK Runtime Environment (build 9.0.4+12-Debian-4)
OpenJDK 64-Bit Server VM (build 9.0.4+12-Debian-4, mixed mode)

But before running the actual code, I've ran into issues with installing Thrift from scratch under my openjdk:9 container:

compile:
    [javac] Compiling 7 source files to /tmp/thrift-0.12.0/tutorial/java/build
    [javac] /tmp/thrift-0.12.0/tutorial/java/gen-java/shared/SharedService.java:10: error: package javax.annotation is not visible
    [javac] @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.12.0)", date = "2019-01-30")
    [javac]       ^
    [javac]   (package javax.annotation is declared in module java.xml.ws.annotation, which is not in the module graph)
    [javac] /tmp/thrift-0.12.0/tutorial/java/gen-java/shared/SharedStruct.java:10: error: package javax.annotation is not visible
    [javac] @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.12.0)", date = "2019-01-30")
    [javac]       ^
    [javac]   (package javax.annotation is declared in module java.xml.ws.annotation, which is not in the module graph)
    [javac] /tmp/thrift-0.12.0/tutorial/java/gen-java/tutorial/Calculator.java:10: error: package javax.annotation is not visible
    [javac] @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.12.0)", date = "2019-01-30")
    [javac]       ^
    [javac]   (package javax.annotation is declared in module java.xml.ws.annotation, which is not in the module graph)
    [javac] /tmp/thrift-0.12.0/tutorial/java/gen-java/tutorial/Work.java:19: error: package javax.annotation is not visible
    [javac] @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.12.0)", date = "2019-01-30")
    [javac]       ^
    [javac]   (package javax.annotation is declared in module java.xml.ws.annotation, which is not in the module graph)
    [javac] /tmp/thrift-0.12.0/tutorial/java/gen-java/tutorial/InvalidOperation.java:13: error: package javax.annotation is not visible
    [javac] @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.12.0)", date = "2019-01-30")
    [javac]       ^
    [javac]   (package javax.annotation is declared in module java.xml.ws.annotation, which is not in the module graph)
    [javac] /tmp/thrift-0.12.0/tutorial/java/gen-java/tutorial/Operation.java:14: error: package javax.annotation is not visible
    [javac] @javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.12.0)", date = "2019-01-30")
    [javac]       ^
    [javac]   (package javax.annotation is declared in module java.xml.ws.annotation, which is not in the module graph)
    [javac] 6 errors

I'll look into this, this evening.

[Fokko]

@xhochy Could you rebase onto latest master? Thanks!

=================================================================================
========== [FATAL] Build is configured to require Thrift version 0.9.3 ==========
========== Currently installed: Thrift version 0.12.0
=================================================================================

So I can check against Thrift 0.12.0?

I'm also looking into bumping Thrift: apache/thrift#1723

[jeking3]

This issue would not be resolved in thrift until 0.13.0. There's a fix in the CI pipeline for it right now thanks for @Fokko.

[Fokko]

@jeking3 I can do a hotfix in the Parquet CI pipeline, thanks for the clarification.

Apart from that, looking good @xhochy. The missing annotation symbol errors that you've mentioned earlier are gone.

Most modules compile, except the Scala one:

[ERROR] error: error while loading package, Missing dependency 'object java.lang.Object in compiler mirror', required by /root/.m2/repository/org/scala-lang/scala-library/2.10.6/scala-library-2.10.6.jar(scala/package.class)
[ERROR] error: error while loading package, Missing dependency 'object java.lang.Object in compiler mirror', required by /root/.m2/repository/org/scala-lang/scala-library/2.10.6/scala-library-2.10.6.jar(scala/runtime/package.class)
[ERROR] error: scala.reflect.internal.MissingRequirementError: object java.lang.Object in compiler mirror not found.
[ERROR] 	at scala.reflect.internal.MissingRequirementError$.signal(MissingRequirementError.scala:16)
[ERROR] 	at scala.reflect.internal.MissingRequirementError$.notFound(MissingRequirementError.scala:17)

But this is expected since Scala 2.10.6 doesn't work onder JDK11: https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html

[xhochy]

@Fokko rebased.