Skip to content

[PARQUET-1507] Bump Apache Thrift to 0.12.0 #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gszadovszky merged 2 commits into from
Jan 30, 2019
Merged

[PARQUET-1507] Bump Apache Thrift to 0.12.0 #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a217b
[PARQUET-1507] Bump Apache Thrift to 0.12.0
Jan 24, 2019
8755b9f
[PARQUET-1507] Bump Apache Thrift to 0.12.0
Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ Parquet-MR uses Maven to build and depends on the thrift compiler (protoc is now
To build and install the thrift compiler, run:

```
wget -nv http://archive.apache.org/dist/thrift/0.9.3/thrift-0.9.3.tar.gz
tar xzf thrift-0.9.3.tar.gz
cd thrift-0.9.3
wget -nv http://archive.apache.org/dist/thrift/0.12.0/thrift-0.12.0.tar.gz
tar xzf thrift-0.12.0.tar.gz
cd thrift-0.12.0
chmod +x ./configure
./configure --disable-gen-erl --disable-gen-hs --without-ruby --without-haskell --without-erlang --without-php --without-nodejs
sudo make install
```

If you're on OSX and use homebrew, you can instead install Thrift 0.9.x with `brew` and ensure that it comes first in your `PATH`.
If you're on OSX and use homebrew, you can instead install Thrift 0.12.0 with `brew` and ensure that it comes first in your `PATH`.

```
brew install thrift@0.9
export PATH="/usr/local/opt/thrift@0.9/bin:$PATH"
brew install thrift@0.12.0
export PATH="/usr/local/opt/thrift@0.12.0/bin:$PATH"
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, All.
Is this working as of today?

Copy link
Contributor Author

@Fokko Fokko Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are still working on a fix: Homebrew/homebrew-core#35796

But with Thrift 0.11.0 is should work as well: brew install thrift.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for informing that, @Fokko !

```

### Build Parquet with Maven
Expand Down
8 changes: 5 additions & 3 deletions dev/travis-before_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
# This script gets invoked by .travis.yml in the before_install step
################################################################################

export THIFT_VERSION=0.12.0

set -e
date
sudo apt-get update -qq
Expand All @@ -27,9 +29,9 @@ sudo apt-get install -qq build-essential pv autoconf automake libtool curl make
libevent-dev automake libtool flex bison pkg-config g++ libssl-dev xmlstarlet
date
pwd
wget -nv http://archive.apache.org/dist/thrift/0.9.3/thrift-0.9.3.tar.gz
tar zxf thrift-0.9.3.tar.gz
cd thrift-0.9.3
wget -nv http://archive.apache.org/dist/thrift/${THIFT_VERSION}/thrift-${THIFT_VERSION}.tar.gz
tar zxf thrift-${THIFT_VERSION}.tar.gz
cd thrift-${THIFT_VERSION}
chmod +x ./configure
./configure --disable-gen-erl --disable-gen-hs --without-ruby --without-haskell --without-erlang --without-php --without-nodejs
sudo make install
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@
<pig.version>0.16.0</pig.version>
<pig.classifier>h2</pig.classifier>
<thrift-maven-plugin.version>0.10.0</thrift-maven-plugin.version>
<thrift.version>0.9.3</thrift.version>
<format.thrift.version>0.9.3</format.thrift.version>
<thrift.version>0.12.0</thrift.version>
<format.thrift.version>0.12.0</format.thrift.version>
<fastutil.version>7.0.13</fastutil.version>
<semver.api.version>0.9.33</semver.api.version>
<slf4j.version>1.7.22</slf4j.version>
Expand Down