PARQUET-1499: Add Java 11 to Travis #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszadovszky
requested changes
Jan 22, 2019
Contributor
gszadovszky
left a comment
gszadovszky
left a comment
There was a problem hiding this comment.
Thanks a lot for this fix. Please, check my comments.
Fokko
force-pushed
the
fd-add-java-11-builds
branch
from
e401cfa to
d4e8ebb
Compare
gszadovszky
approved these changes
Jan 22, 2019
Contributor
gszadovszky
left a comment
gszadovszky
left a comment
There was a problem hiding this comment.
Waiting for the fixes of the java11 related issues. I'll push it if Travis tests pass.
nandorKollar
approved these changes
Jan 22, 2019
Fokko
force-pushed
the
fd-add-java-11-builds
branch
from
d4e8ebb to
a103088
Compare
Contributor
Author
|
Rebased. |
Fokko
force-pushed
the
fd-add-java-11-builds
branch
from
a103088 to
7ebbfb7
Compare
Contributor
Author
|
Thrift was using Gradle 4.4.1, but has been updated to 5.1.1 which supports Java11: |
Fokko
force-pushed
the
fd-add-java-11-builds
branch
from
7ebbfb7 to
54d8490
Compare
zivanfi
changed the title
zivanfi
changed the title
Fokko
force-pushed
the
fd-add-java-11-builds
branch
4 times, most recently
from
71c35c9 to
e9485ab
Compare
Fokko
force-pushed
the
fd-add-java-11-builds
branch
from
e9485ab to
9da1fe1
Compare
Contributor
Author
Got some weird warnings from generated code: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.9.1:javadoc (default-cli) on project parquet-format-structures: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/7/docs/api/ are in the unnamed module. [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:394: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:407: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:84: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:150: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:159: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:29: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag <
So we can run it in Docker as well
Fokko
force-pushed
the
fd-add-java-11-builds
branch
from
9da1fe1 to
ad4697e
Compare
Contributor
Author
|
Rebased onto master and it is green now :-) |
shangxinli
pushed a commit
to shangxinli/parquet-mr
that referenced
this pull request
Dec 16, 2019
Got some weird warnings from generated code: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.9.1:javadoc (default-cli) on project parquet-format-structures: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/7/docs/api/ are in the unnamed module. [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:394: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:407: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:84: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:150: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:159: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:29: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/ColumnIndex.java:49: warning - invalid usage of tag < [ERROR] /home/travis/build/apache/parquet-mr/parquet-format-structures/target/generated-sources/thrift/org/apache/parquet/format/OffsetIndex.java:21: warning - invalid usage of tag <
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/PARQUET-1497