Skip to content

Fix unstable test: handle MiniCluster shutdown gracefully in collect … #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Dec 28, 2025
Merged

Fix unstable test: handle MiniCluster shutdown gracefully in collect … #6913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...on-flink-common/src/test/java/org/apache/paimon/flink/PrimaryKeyFileStoreTableITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,21 @@ private CloseableIterator<Row> collect(TableResult result, int timeout) {
return;
}
} catch (Exception e) {
// If we can't get job status, assume the job has terminated.
// This handles cases where MiniCluster has already shut down.
// Similar to Flink's CollectResultFetcher behavior.
return;
}
}
// Only cancel if job is not already terminated
try {
if (!client.getJobStatus().get().isGloballyTerminalState()) {
client.cancel();
throw new RuntimeException(e);
}
} catch (Exception e) {
// If we can't check status or cancel, assume job has terminated.
// This handles IllegalStateException when MiniCluster is shut down.
}
client.cancel();
});
timeoutThread.start();
return result.collect();
Expand Down