Fix unstable test: handle MiniCluster shutdown gracefully in collect … #6913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @Shekharrajak for the contribution. +1 |
jerry-024
added a commit
to jerry-024/paimon
that referenced
this pull request
Dec 29, 2025
* upstream/master: (51 commits) [test] Fix unstable test: handle MiniCluster shutdown gracefully in collect method (apache#6913) [python] fix ray dataset not lazy loading issue when parallelism = 1 (apache#6916) [core] Refactor ExternalPathProviders abstraction [spark] fix Merge Into unstable tests (apache#6912) [core] Enable Entropy Inject for data file path to prevent being throttled by object storage (apache#6832) [iceberg] support millisecond timestamps in iceberg compatibility mode (apache#6352) [spark] Handle NPE for pushdown aggregate when a datasplit has a null max/min value (apache#6611) [test] Fix unstable case testLimitPushDown [core] Refactor row id pushdown to DataEvolutionFileStoreScan [spark] paimon-spark supports row id push down (apache#6697) [spark] Support compact_database procedure (apache#6328) (apache#6910) [lucene] Fix row count in IndexManifestEntry [test] Remove unstable test: AppendTableITCase.testFlinkMemoryPool [core] Refactor Global index writer and reader for Btree [core] Minor refactor to magic number into footer [core] Support btree global index in paimon-common (apache#6869) [spark] Optimize compact for data-evolution table, commit multiple times to avoid out of memory (apache#6907) [rest] Add fromSnapshot to rollback (apache#6905) [test] Fix unstable RowTrackingTestBase test [core] Simplify FileStoreCommitImpl to extract some classes (apache#6904) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[flink] Fix unstable test: handle MiniCluster shutdown gracefully in collect method
Purpose
Linked issue: close #5563
This PR fixes the unstable test
PrimaryKeyFileStoreTableITCase.testNoChangelogProducerStreamingRandomby addressing a race condition in thecollectmethod. The timeout thread was attempting to cancel jobs after the MiniCluster had already shut down, causingIllegalStateExceptionand premature test termination. The fix follows the pattern used in Flink'sCollectResultFetcherto gracefully handle shutdown scenarios.Tests
PrimaryKeyFileStoreTableITCase.testNoChangelogProducerStreamingRandomwhich was failing intermittently with:IllegalStateException: MiniCluster is not yet running or has already been shut downThe fix ensures that:
getJobStatus()throws an exception (e.g., MiniCluster shutdown), we assume the job has terminated instead of attempting cancellationIllegalStateExceptiongracefullyAPI and Format
No API or storage format changes.
Documentation
No documentation changes needed. This is a test stability fix.