Skip to content

Allow override surefire plugin group #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leerho merged 1 commit into from
Jan 8, 2026
Merged

Allow override surefire plugin group #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,20 @@ under the License.
</dependencies>

<build>
<pluginManagement>
<plugins>
<plugin>
<!-- Apache Parent pom, pluginManagement-->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<!-- by default, exclude all snapshot targets -->
<!-- this will be overridden on dedicated profile -->
<excludedGroups>${testng.generate-java-files},${testng.check-cpp-files},${testng.check-go-files},${testng.check-cpp-historical-files}</excludedGroups>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>

<plugin>
Expand All @@ -143,7 +157,7 @@ under the License.
<fork>true</fork>
<release>${java.version}</release>
<compilerArgs>
<arg>-J${jvm.options}</arg> <!-- comma separated or separate args -->
<arg>-J${jvm.options}</arg> <!-- comma separated or separate args -->
</compilerArgs>
</configuration>
</plugin>
Expand Down Expand Up @@ -224,7 +238,7 @@ under the License.
<doclint>all,-missing</doclint>
<release>${java.version}</release>
<additionalJOptions> <!-- requires -J prefix -->
<additionalJoption>-J${jvm.options}</additionalJoption>
<additionalJoption>-J${jvm.options}</additionalJoption>
</additionalJOptions>
</configuration>
<executions>
Expand Down Expand Up @@ -274,8 +288,6 @@ under the License.
<useManifestOnlyJar>false</useManifestOnlyJar>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
<reportsDirectory>${project.build.directory}/test-output/${maven.build.timestamp}</reportsDirectory>
<excludedGroups>${testng.generate-java-files},${testng.check-cpp-files},${testng.check-go-files},
${testng.check-cpp-historical-files}</excludedGroups> <!-- do not indent -->
Copy link
Member

@leerho leerho Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had set this up so that an ordinary "mvn test" would not generate the java files and run the tests against the other languages. These are run with specific profiles.

Now that we are adding more languages into the mix, I am not clear on what you have in mind.

Copy link
Member Author

@tisonkun tisonkun Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #711 (comment).

This config would be still applied, but from the /pluginManagement/plugins/plugin section that can be override.

This PR is a no change for developer who only runs mvn test.

</configuration>
</plugin>

Expand Down Expand Up @@ -581,7 +593,7 @@ ${testng.check-cpp-historical-files}</excludedGroups> <!-- do not indent -->
</pluginManagement>
</build>
</profile>

<profile>
<id>check-cpp-historical-files</id>
<build>
Expand Down