Allow override surefire plugin group #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
leerho
reviewed
Jan 7, 2026
| <redirectTestOutputToFile>true</redirectTestOutputToFile> | ||
| <reportsDirectory>${project.build.directory}/test-output/${maven.build.timestamp}</reportsDirectory> | ||
| <excludedGroups>${testng.generate-java-files},${testng.check-cpp-files},${testng.check-go-files}, | ||
| ${testng.check-cpp-historical-files}</excludedGroups> <!-- do not indent --> |
Member
There was a problem hiding this comment.
I had set this up so that an ordinary "mvn test" would not generate the java files and run the tests against the other languages. These are run with specific profiles.
Now that we are adding more languages into the mix, I am not clear on what you have in mind.
Member
Author
There was a problem hiding this comment.
See #711 (comment).
This config would be still applied, but from the /pluginManagement/plugins/plugin section that can be override.
This PR is a no change for developer who only runs mvn test.
leerho
reviewed
Jan 7, 2026
leerho
requested changes
Jan 7, 2026
Member
leerho
left a comment
leerho
left a comment
There was a problem hiding this comment.
I have a couple of questions that need clarification.
leerho
requested changes
Jan 7, 2026
Member
leerho
left a comment
leerho
left a comment
There was a problem hiding this comment.
Some questions that need clarification.
leerho
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the exclude all groups config is defined in
/plugins/pluginand thus it overrides any other configs defined in the/pluginManagementsection.