feat:add_additional_char_support_rpad #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderfender
changed the title
comphead
reviewed
Sep 24, 2025
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
comphead
reviewed
Sep 24, 2025
native/spark-expr/src/static_invoke/char_varchar_utils/read_side_padding.rs
Outdated
Show resolved
Hide resolved
comphead
reviewed
Sep 24, 2025
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
coderfender
force-pushed
the
add_additional_support_to_padding_strings
branch
from
85791b8 to
dccd14a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2436 +/- ##
============================================
+ Coverage 56.12% 58.48% +2.35%
- Complexity 976 1440 +464
============================================
Files 119 146 +27
Lines 11743 13517 +1774
Branches 2251 2350 +99
============================================
+ Hits 6591 7905 +1314
- Misses 4012 4379 +367
- Partials 1140 1233 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2435 .
Rationale for this change
PR : #2435
What changes are included in this PR?
#2435
How are these changes tested?
Unit testing