Skip to content

Conversation

@coderfender
Copy link
Contributor

@coderfender coderfender commented Aug 9, 2025

Which issue does this PR close?

Closes #2101

Closes #.

Rationale for this change

Moving towards goal to support more native operations and not fallback to spark .

What changes are included in this PR?

How are these changes tested?

Unit tests in comet expression suite

If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderfender coderfender changed the title implement_comet_native_lpad_expr feat : implement_comet_native_lpad_expr Aug 11, 2025
@coderfender coderfender changed the title feat : implement_comet_native_lpad_expr feat: implement_comet_native_lpad_expr Aug 11, 2025
@coderfender
Copy link
Contributor Author

@mbutrovich , Once the PR #2099 is merged, I plan to change code in this branch to leverage the same class since most of the code for rpad could be leveraged to support lpad operation as well

@coderfender
Copy link
Contributor Author

coderfender commented Sep 16, 2025

@comphead , @mbutrovich I leveraged #2099 to implement lpad expression in the same class given the high similarity among the expressions. Please take a look whenever you get a chance .
Thank you

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.56%. Comparing base (f09f8af) to head (40cb4fe).
⚠️ Report is 565 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2102      +/-   ##
============================================
+ Coverage     56.12%   58.56%   +2.43%     
- Complexity      976     1445     +469     
============================================
  Files           119      146      +27     
  Lines         11743    13541    +1798     
  Branches       2251     2356     +105     
============================================
+ Hits           6591     7930    +1339     
- Misses         4012     4379     +367     
- Partials       1140     1232      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderfender
Copy link
Contributor Author

Thank you @comphead , It seems like the tests mentioned are adding non space chars while we still only support spaces (which will be fixed with #2436 ). Do you think it is a good idea to hold on to this PR until #2436 is closed ?

@coderfender
Copy link
Contributor Author

@comphead Changes are ready for review (please rerun the failed test caused due to a transient error)

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @coderfender I think we very close

@coderfender
Copy link
Contributor Author

Thank you @comphead . Let me push fixes right away and re run CI

@coderfender coderfender requested a review from comphead October 1, 2025 19:48
@coderfender coderfender force-pushed the add_lpad_expr_support branch from 7d602f4 to 91ec7ee Compare October 1, 2025 20:15
@coderfender coderfender force-pushed the add_lpad_expr_support branch from 91ec7ee to 40cb4fe Compare October 1, 2025 20:33
@coderfender
Copy link
Contributor Author

@comphead thank you for kicking off the CI . Please review the changes whenever you get a chance
Thank you

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coderfender I think this PR is good to go

@coderfender
Copy link
Contributor Author

Thank you very much for the swift approval @comphead

@coderfender
Copy link
Contributor Author

I will raise a doc change PR shortly

@comphead comphead merged commit 5062735 into apache:main Oct 2, 2025
102 checks passed
@coderfender coderfender deleted the add_lpad_expr_support branch October 2, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support native lpad expression

3 participants